From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E58E2A0A0A; Thu, 20 May 2021 20:09:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E4E840143; Thu, 20 May 2021 20:09:54 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7992040041 for ; Thu, 20 May 2021 20:09:52 +0200 (CEST) IronPort-SDR: 3dFTUxtm/g/yLMPeCOY8vx+1xy45mBCW/hsU7QV20p7nJNlssm3A5I0NGr4c7FsBL2V/jQCoFs AQfdZ86e6CIQ== X-IronPort-AV: E=McAfee;i="6200,9189,9990"; a="201352364" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="201352364" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 11:09:51 -0700 IronPort-SDR: gU2SviXbilqbW/FYKpHwNxF1HhmU+BtJ1pKLBwv9k5A1f9ShH1xHUlMjIvlQ9YzAxmWni41bU7 pZn9rzhLTYNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="474141923" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by orsmga001.jf.intel.com with ESMTP; 20 May 2021 11:09:50 -0700 From: Timothy McDaniel To: Cc: dev@dpdk.org, erik.g.carrillo@intel.com, harry.van.haaren@intel.com, jerinj@marvell.com, thomas@monjalon.net, david.marchand@redhat.com, timothy.mcdaniel@intel.com Date: Thu, 20 May 2021 13:08:02 -0500 Message-Id: <1621534082-8996-1-git-send-email-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1620843888-882873-1-git-send-email-timothy.mcdaniel@intel.com> References: <1620843888-882873-1-git-send-email-timothy.mcdaniel@intel.com> Subject: [dpdk-dev] [PATCH v2] event/dlb2: make scalar mode dequeue the default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Optimized dequeue using x86 vector instructions was added in 21.05, but due to limited testing the default has been changed back to the scalar mode implementation. The vector mode implementation can be enabled via the devargs option "vector_opts_enabled=". Fixes: 000a7b8e7582 ("event/dlb2: optimize dequeue operation") Signed-off-by: Timothy McDaniel --- Cc: timothy.mcdaniel@intel.com --- doc/guides/eventdevs/dlb2.rst | 13 +++++++++++++ drivers/event/dlb2/dlb2.c | 24 ++++++++++++------------ drivers/event/dlb2/dlb2_priv.h | 6 +++--- 3 files changed, 28 insertions(+), 15 deletions(-) diff --git a/doc/guides/eventdevs/dlb2.rst b/doc/guides/eventdevs/dlb2.rst index c60c454d6..acdb00587 100644 --- a/doc/guides/eventdevs/dlb2.rst +++ b/doc/guides/eventdevs/dlb2.rst @@ -367,3 +367,16 @@ Class of service can be specified in the devargs, as follows .. code-block:: console --vdev=dlb2_event,cos=<0..4> + +Use X86 Vector Instructions +~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +DLB supports using x86 vector instructions to optimize the data path. + +The default mode of operation is to use scalar instructions, but +the use of vector instructions can be enabled in the devargs, as +follows + + .. code-block:: console + + --allow ea:00.0,vector_opts_enabled= diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 588c41ee7..0022f65fc 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -376,11 +376,11 @@ set_default_depth_thresh(const char *key __rte_unused, } static int -set_vector_opts_disab(const char *key __rte_unused, +set_vector_opts_enab(const char *key __rte_unused, const char *value, void *opaque) { - bool *dlb2_vector_opts_disabled = opaque; + bool *dlb2_vector_opts_enabled = opaque; if (value == NULL || opaque == NULL) { DLB2_LOG_ERR("NULL pointer\n"); @@ -388,9 +388,9 @@ set_vector_opts_disab(const char *key __rte_unused, } if ((*value == 'y') || (*value == 'Y')) - *dlb2_vector_opts_disabled = true; + *dlb2_vector_opts_enabled = true; else - *dlb2_vector_opts_disabled = false; + *dlb2_vector_opts_enabled = false; return 0; } @@ -1469,7 +1469,7 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2, #else if ((qm_port->cq_depth > 64) || (!rte_is_power_of_2(qm_port->cq_depth)) || - (dlb2->vector_opts_disabled == true)) + (dlb2->vector_opts_enabled == false)) qm_port->use_scalar = true; #endif @@ -1665,7 +1665,7 @@ dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2, #else if ((qm_port->cq_depth > 64) || (!rte_is_power_of_2(qm_port->cq_depth)) || - (dlb2->vector_opts_disabled == true)) + (dlb2->vector_opts_enabled == false)) qm_port->use_scalar = true; #endif @@ -4434,7 +4434,7 @@ dlb2_primary_eventdev_probe(struct rte_eventdev *dev, dlb2->poll_interval = dlb2_args->poll_interval; dlb2->sw_credit_quanta = dlb2_args->sw_credit_quanta; dlb2->default_depth_thresh = dlb2_args->default_depth_thresh; - dlb2->vector_opts_disabled = dlb2_args->vector_opts_disabled; + dlb2->vector_opts_enabled = dlb2_args->vector_opts_enabled; err = dlb2_iface_open(&dlb2->qm_instance, name); if (err < 0) { @@ -4538,7 +4538,7 @@ dlb2_parse_params(const char *params, DLB2_POLL_INTERVAL_ARG, DLB2_SW_CREDIT_QUANTA_ARG, DLB2_DEPTH_THRESH_ARG, - DLB2_VECTOR_OPTS_DISAB_ARG, + DLB2_VECTOR_OPTS_ENAB_ARG, NULL }; if (params != NULL && params[0] != '\0') { @@ -4653,11 +4653,11 @@ dlb2_parse_params(const char *params, } ret = rte_kvargs_process(kvlist, - DLB2_VECTOR_OPTS_DISAB_ARG, - set_vector_opts_disab, - &dlb2_args->vector_opts_disabled); + DLB2_VECTOR_OPTS_ENAB_ARG, + set_vector_opts_enab, + &dlb2_args->vector_opts_enabled); if (ret != 0) { - DLB2_LOG_ERR("%s: Error parsing vector opts disabled", + DLB2_LOG_ERR("%s: Error parsing vector opts enabled", name); rte_kvargs_free(kvlist); return ret; diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h index b1225af37..bb87072da 100644 --- a/drivers/event/dlb2/dlb2_priv.h +++ b/drivers/event/dlb2/dlb2_priv.h @@ -37,7 +37,7 @@ #define DLB2_POLL_INTERVAL_ARG "poll_interval" #define DLB2_SW_CREDIT_QUANTA_ARG "sw_credit_quanta" #define DLB2_DEPTH_THRESH_ARG "default_depth_thresh" -#define DLB2_VECTOR_OPTS_DISAB_ARG "vector_opts_disable" +#define DLB2_VECTOR_OPTS_ENAB_ARG "vector_opts_enable" /* Begin HW related defines and structs */ @@ -565,7 +565,7 @@ struct dlb2_eventdev { uint32_t new_event_limit; int max_num_events_override; int num_dir_credits_override; - bool vector_opts_disabled; + bool vector_opts_enabled; volatile enum dlb2_run_state run_state; uint16_t num_dir_queues; /* total num of evdev dir queues requested */ union { @@ -623,7 +623,7 @@ struct dlb2_devargs { int poll_interval; int sw_credit_quanta; int default_depth_thresh; - bool vector_opts_disabled; + bool vector_opts_enabled; }; /* End Eventdev related defines and structs */ -- 2.23.0