From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABF9DA00C2; Thu, 13 Oct 2022 14:18:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E59642DC8; Thu, 13 Oct 2022 14:18:11 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 9A43C42DC7; Thu, 13 Oct 2022 14:18:10 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5C6235C0084; Thu, 13 Oct 2022 08:18:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 13 Oct 2022 08:18:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665663489; x= 1665749889; bh=jkDjPkGm4t2/T7EAZ5G1FKsgiuY1BJMbEEwJHKNohQI=; b=t iSNE/jlBllWqt1vzbWv6z81L3GRBtjsa1hYJLtBzcesuQ2wPw6MzKWyFcgxOFG3X yfuXGwtlto11Ky5aOm5OI323SC9mNGnBia/+THW51A9ZNJTk2H86uzU+jHaBkLda 2IfXGVCAU21rVFtp8brI4FTcWNYp8dOJxv5Bn+fHa9mX30UgsCPgt9WGzBQ/SXG4 01ppVTGFp54BZmZ7IZbJSXd5Sw2a8IHu9x5q0B6pLG17on1r2SYkf9mLEOw2vlCH JsdArejY0qmRbpLnU8OFLA9Tm7/xDoyodg6i69BHq2zKqvD1V6QG2p0rf+VH9r2e fHEmZNTife7GQnEkq63vg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665663489; x= 1665749889; bh=jkDjPkGm4t2/T7EAZ5G1FKsgiuY1BJMbEEwJHKNohQI=; b=q lGkHKh66y90RpKXTMmzuCsJr4eDrGmPARYxPWH3GRmtQEp6d6ss42cTfGTse3pnB tThIXmsM3Ew81Muu08Mukiwt0dXlzc2UAe1d+XbCZi5AFq3nF0qidzd366J0C+jP dn941ie4+O6Hw/LfrD0b+taX/5ObL092NH6vl1vKzM5UcWEcPBXklO2Bzf1vN6fn YGfaIIn7+2X+H5/DMCTJ3ooxH9thzgIXeNvyKgODrWNMcauRNVFk7q+PjLRxTEN9 hkMED7fusOOnQQTkQHEOQavMAeDIK9nqFciMUGWxUgpKPR9E8npCRkexqDceYhIv MpHSuM86QGWtf0Kvsupow== X-ME-Sender: <xms:_wFIYztXULqP7tDdvYlXyBg5Yl-MhtprplEAGnE7h9qQhjeVdeh7cA> <xme:_wFIY0dC7l7Aovz6s8Wr2Uxmt-BduBqH-cy1jSPMtkiykWgeL5iXZGglKQVausGjO hfB1WchM_xmvJFkpQ> X-ME-Received: <xmr:_wFIY2xa0h2mkyIMJ63z8AOWh4tYVQAy9x_sOQKFamQhyMzFxO4RDcII48hlAjnbcDz0t7udGekTklaiGd5XEgYsUQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:_wFIYyP0QPin0-LG0uMovMRg46xc5skRdAK8_DFVAtMHir8yRYPXEw> <xmx:_wFIYz8ph7UExgXIcODJvAXw2pASb3ryqxzdIYm9a_k7YtouJED-Tg> <xmx:_wFIYyXGleKG35qmv4KD6h1A1XGRPsTGbZK7vOPbHEX2rxVb2_bZyA> <xmx:AQJIY_uq4AQgOdFy3ryCJjjL-7V6k2VC6LZfk--Y6lLJNzKCVfCiJQ> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 08:18:05 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ilya Maximets <i.maximets@ovn.org> Cc: i.maximets@ovn.org, dev@dpdk.org, stable@dpdk.org, Ajit Khaparde <ajit.khaparde@broadcom.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Haiyue Wang <haiyue.wang@intel.com>, John Daley <johndale@cisco.com>, Guoyang Zhou <zhouguoyang@huawei.com>, "Min Hu (Connor)" <humin29@huawei.com>, Beilei Xing <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Rosen Xu <rosen.xu@intel.com>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Liron Himi <lironh@marvell.com>, Jiawen Wu <jiawenwu@trustnetic.com>, Ori Kam <orika@nvidia.com>, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, david.marchand@redhat.com, olivier.matz@6wind.com Subject: Re: [PATCH] doc: fix support table for ETH and VLAN flow items Date: Thu, 13 Oct 2022 14:18:03 +0200 Message-ID: <16216253.dW097sEU6C@thomas> In-Reply-To: <bd3473d5-0864-f43b-de65-5be00483b5a0@ovn.org> References: <20220316120157.390311-1-i.maximets@ovn.org> <6479268.QJadu78ljV@thomas> <bd3473d5-0864-f43b-de65-5be00483b5a0@ovn.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 13/10/2022 13:01, Ilya Maximets: > On 10/12/22 17:30, Thomas Monjalon wrote: > > 07/10/2022 13:55, Ilya Maximets: > >> On 10/7/22 13:50, Ilya Maximets wrote: > >>> On 9/12/22 12:09, Thomas Monjalon wrote: > >>>> 16/03/2022 13:01, Ilya Maximets: > >>>>> 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk. > >>>>> Other drivers doesn't support it. Most of them (like i40e) just > >>>>> ignore it silently. Some drivers (like mlx4) never had a full > >>>>> support of the eth item even before introduction of 'has_vlan' > >>>>> (mlx4 allows to match on the destination MAC only). > >>>>> > >>>>> Same for the 'has_more_vlan' flag of the vlan item. > >>>>> > >>>>> Changing the support level to 'partial' for all such drivers. > >>>>> This doesn't solve the issue, but at least marks the problematic > >>>>> drivers. > >>>> > >>>> You changed "eth" and "vlan" from "Y" to "P". > >>>> The field "has_vlan" is part of "rte_flow_item_eth", > >>>> and "has_more_vlan" is part of "rte_flow_item_vlan", > >>>> so I agree we need to change both items to "partial support". > >>>> It looks to be a good change, just needs to more explicit, > >>>> adding this kind of explanation about the fields. > >>> > >>> I can add this to the commit message. Should I also add > >>> some note alongside the table in that documentation page? > > > > I'm afraid it can be long and complex to add notes in the page > > about what is missing to get complete support for each feature/PMD. > > I think you can just re-spin with a clear explanation in the commit, > > so PMD maintainers can refer to it. > > OK. v2 sent here: > https://patches.dpdk.org/project/dpdk/patch/20221013104849.2677995-1-i.maximets@ovn.org/ Thank you, I'm currently working on the rte_flow_items to use structs from librte_net.