From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C3AB795AA for <dev@dpdk.org>; Mon, 7 Dec 2015 12:40:13 +0100 (CET) Received: by wmww144 with SMTP id w144so146296445wmw.0 for <dev@dpdk.org>; Mon, 07 Dec 2015 03:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Dgxe7D/Otv1Pk9WWRV1tH5RQ8UKxdIFgHVMPX2GvKdU=; b=gMbuBeWAxAW3Ah96pPq2Eu9tx+8dy/ZZs7HNAvd/VmW8Qm0sBXS1aXWWax1d8hs8hz IXocHx2EcK13K/cgufjvd2ZzZd5rLsml3BwIra+eCrwRbQedxhWM1lBIufzRDGIs7wwE +5PZggp/qeAqgVbkBoG+fq1sNxhRH/Z+zMp3QF53mVZGyyDgN7esyVOsjFd3C1Hl2pPQ cBYsJN1HW+/1GDG7gj2blSa7DPEYg0f6MJ5QC5hq5Y2SgkVbFIJ2FYzEqys3Y5wuSaBd PDDqD0cjQjJ80eaavh3kb9FkQren2cELOmaa0JF9krGalPAF96ZeiZnofeSA6uxT5CB6 Pspw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Dgxe7D/Otv1Pk9WWRV1tH5RQ8UKxdIFgHVMPX2GvKdU=; b=MYc4bURl7ArAptV5pwNPMWz1ouXRYIsPHBVpwb0DMFdRMPqYLTIbNcBJXdpPq1UMRd U6hxUS4kYFT7HvsvO5bwTGnTR+Exe+3BgHS0iEdbkiTELkuMalSrV50ky4QtC0N3zcYt 2A4dZA9je8pTeAYdQ2kwXTnpxmUTya5edKZRAQGzv9ww0hdHGbECzqvcOlI/zRDF0JYJ xJybsvgYKMt9ruXsucOvESqS3/OLf1BrYA4+wn5opOi0HaX6hL7hE7DE8lYEjpCk/CU5 7QpxRRWRciDSSAGuP4Np8j+jrz6AVIrLtF1QnYkBS5fvER1Imc1RPziqb3f9GkmxtAmU vH5w== X-Gm-Message-State: ALoCoQlPyrpIV/YTgFi5D2FmEmAEwcsZ3v1CYs1R5OZZfsMmqrTfYEJT1JYwoxRIkIY5J6gGIx1VZ6wqo8r67k52ZsW9KO/YJw== X-Received: by 10.28.130.7 with SMTP id e7mr20167185wmd.68.1449488413638; Mon, 07 Dec 2015 03:40:13 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id qm9sm24753144wjc.39.2015.12.07.03.40.12 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 03:40:13 -0800 (PST) Date: Mon, 07 Dec 2015 03:40:13 -0800 (PST) X-Google-Original-Date: Mon, 07 Dec 2015 12:39 +0100 From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Jerin Jacob <jerin.jacob@caviumnetworks.com> Message-ID: <1624480.dTEes5qyS3@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151207072644.GA3950@localhost.localdomain> References: <1449417564-29600-1-git-send-email-jerin.jacob@caviumnetworks.com> <1631625.Dg38D5sl3P@xps13> <20151207072644.GA3950@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] fix performance/cache resource issues with 128-byte cache line targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 07 Dec 2015 11:40:13 -0000 2015-12-07 12:56, Jerin Jacob: > On Sun, Dec 06, 2015 at 05:30:50PM +0100, Thomas Monjalon wrote: > > 2015-12-06 21:29, Jerin Jacob: > > > This patchset fixes performance/cache resource issues with 128-byte cache line targets > > > found in mbuf and bitmap DPDK libraries > > > > > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on > > > 128-bytes cache line size target. > > > > When introducing IBM Power8, we failed to clean the cache line size definition. > > I promised to not forget this issue in this thread with Neil: > > http://dpdk.org/ml/archives/dev/2014-December/009439.html > > > > It is defined in > > config/defconfig_* > > mk/machine/*/rte.vars.mk > > mk/arch/*/rte.vars.mk > > rte_memory.h > > rte_kni_common.h > > > > It should be defined only in the config files. > > When we will introduce a configure script, we should be able to detect it. > > > > Please Jerin, as ThunderX maintainer, may you help to fix this old mess? > > Yes Thomas, I will takeup this issue when we will have configure script. I thought we could start setting the value in only one place. The detection in configure script would be another step. > apart from that, content of the this patch will be still valid > as the fix going to be generating cache line define from the config file.