DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/1] devtools: avoid installing static binaries
Date: Wed, 13 Jan 2021 23:01:34 +0100	[thread overview]
Message-ID: <1624576.mXulGEC3Iq@thomas> (raw)
In-Reply-To: <20210113190542.223445-1-thomas@monjalon.net>

13/01/2021 20:05, Thomas Monjalon:
> When testing compilation and checking ABI compatibility,
> there is no real need of static binaries eating disks.
> 
> The static linkage of applications was already well tested,
> though the static examples tested with meson were limited to "l3fwd" only.
> The static build test with make is limited to "helloworld" example.
> 
> The ABI compatibility is checked on shared libraries,
> and there is no need to test again on similar builds.
> A new parameter is added to the function "build",
> so the ABI check is enabled only for native gcc and clang shared builds,
> 32-bit, generic armv8 and ppc cross compilations.
> In other words, it is disabled for some static builds and some Arm ones.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2:
> - separate ABI check enablement from default library
> - disable ABI check in specific Arm builds
> ---
[...]
> -build build-x86-default cc -Dlibdir=lib -Dmachine=$default_machine $use_shared
> +build build-x86-default cc ABI \
> +	-Dlibdir=lib -Dmachine=$default_machine $use_shared

After a second thought, I think this one should be "skipABI".




  reply	other threads:[~2021-01-13 22:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 17:33 [dpdk-dev] [PATCH " Thomas Monjalon
2020-12-07 17:47 ` Bruce Richardson
2020-12-07 18:12   ` Thomas Monjalon
2020-12-08  9:33     ` Bruce Richardson
2020-12-08 15:37 ` David Marchand
2020-12-08 15:52   ` Thomas Monjalon
2021-01-13 19:05 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2021-01-13 22:01   ` Thomas Monjalon [this message]
2021-01-15 15:24     ` David Marchand
2021-01-15 16:02       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1624576.mXulGEC3Iq@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).