From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f179.google.com (mail-we0-f179.google.com
 [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id E95FF5948
 for <dev@dpdk.org>; Fri, 18 Apr 2014 13:42:01 +0200 (CEST)
Received: by mail-we0-f179.google.com with SMTP id x48so1473027wes.38
 for <dev@dpdk.org>; Fri, 18 Apr 2014 04:42:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=RKdXyqkSVXIa3//OIefhPD5lVN0FY/qZfucUcSP/4xk=;
 b=Dlq2SLufU1QEoEHU397ExRYJU8hgc3jT1oYa5AQja4sLd/JZyl9ylAQAQXZvgUQXSK
 fMmkDYFGx2dalX+ecmDYWOFfB2/hmpBctTRNf/p5627lThb1eyBdYgzUYbENHa4xtHZI
 4/XWiPmPW6LBJQ7MOrm97nSEH05a/IAE0ps52kEbFHLctWCm6Z+jD8DtFxt/RGvj8O/D
 N47MJyfqiOCOVAC+I2t3KD/u8UsBdsw9WazenGfRKhwUqjOv5onT2GwncW87mqUVVYVl
 6kiOKQYjrB6kBsfSWbRpsosUfsVt3fFzcjOUMN1CkIrmoHK9eEwjWGjpmZ3MVvYu+wlY
 KDaA==
X-Gm-Message-State: ALoCoQn8WKjHHNL7f/RF4R48kNtBINC3scEtcPvj4CEbyBC+O8xn2mlLqDGYgUPp+R5i3UqmAUtC
X-Received: by 10.194.203.42 with SMTP id kn10mr1118492wjc.54.1397821322691;
 Fri, 18 Apr 2014 04:42:02 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id gc2sm2808526wic.3.2014.04.18.04.42.01
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 18 Apr 2014 04:42:01 -0700 (PDT)
X-Google-Original-Date: Fri, 18 Apr 2014 13:42 +0200
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 18 Apr 2014 04:42:01 -0700 (PDT)
Message-ID: <16254493.92s6zWrT4n@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; )
In-Reply-To: <1397585169-14537-4-git-send-email-nhorman@tuxdriver.com>
References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com>
 <1397585169-14537-4-git-send-email-nhorman@tuxdriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Apr 2014 11:42:02 -0000

2014-04-15 14:05, Neil Horman:
> Rather than have each driver have to remember to add a constructor to it to
> make sure its gets registered properly, wrap that process up in a macro to
> make registration a one line affair.  This also sets the stage for us to
> make registration of vdev pmds and physical pmds a uniform process
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

> --- /dev/null
> +++ b/lib/librte_eal/common/include/rte_pmd.h

So you are creating a new header file for PMD API, right?

According to rte_ethdev.h,
"The Ethernet Device API is composed of two parts:"
"- The application-oriented Ethernet API"
"- The driver-oriented Ethernet API"

So we should implement this macro in rte_ethdev.h.
But maybe you prefer to split this file in two files. If so, please send a 
separated patch for that.

Thanks
-- 
Thomas