From: Huisong Li <lihuisong@huawei.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <ferruh.yigit@intel.com>,
<konstantin.ananyev@intel.com>, <andrew.rybchenko@oktetlabs.ru>
Subject: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag
Date: Tue, 6 Jul 2021 12:10:08 +0800 [thread overview]
Message-ID: <1625544608-30590-1-git-send-email-lihuisong@huawei.com> (raw)
In-Reply-To: <1620460836-38506-1-git-send-email-lihuisong@huawei.com>
Currently, if dev_configure is not called or fails to be called, users
can still call dev_start successfully. So it is necessary to have a flag
which indicates whether the device is configured, to control whether
dev_start can be called and eliminate dependency on user invocation order.
The flag stored in "struct rte_eth_dev_data" is more reasonable than
"enum rte_eth_dev_state". "enum rte_eth_dev_state" is private to the
primary and secondary processes, and can be independently controlled.
However, the secondary process does not make resource allocations and
does not call dev_configure(). These are done by the primary process
and can be obtained or used by the secondary process. So this patch
adds a "dev_configured" flag in "rte_eth_dev_data", like "dev_started".
Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
v1 -> v2:
- adjusting the description of patch.
---
lib/ethdev/rte_ethdev.c | 16 ++++++++++++++++
lib/ethdev/rte_ethdev_core.h | 6 +++++-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index c607eab..6540432 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -1356,6 +1356,13 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
return -EBUSY;
}
+ /*
+ * Ensure that "dev_configured" is always 0 each time prepare to do
+ * dev_configure() to avoid any non-anticipated behaviour.
+ * And set to 1 when dev_configure() is executed successfully.
+ */
+ dev->data->dev_configured = 0;
+
/* Store original config, as rollback required on failure */
memcpy(&orig_conf, &dev->data->dev_conf, sizeof(dev->data->dev_conf));
@@ -1606,6 +1613,8 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
}
rte_ethdev_trace_configure(port_id, nb_rx_q, nb_tx_q, dev_conf, 0);
+ dev->data->dev_configured = 1;
+
return 0;
reset_queues:
eth_dev_rx_queue_config(dev, 0);
@@ -1751,6 +1760,13 @@ rte_eth_dev_start(uint16_t port_id)
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_start, -ENOTSUP);
+ if (dev->data->dev_configured == 0) {
+ RTE_ETHDEV_LOG(INFO,
+ "Device with port_id=%"PRIu16" is not configured.\n",
+ port_id);
+ return -EINVAL;
+ }
+
if (dev->data->dev_started != 0) {
RTE_ETHDEV_LOG(INFO,
"Device with port_id=%"PRIu16" already started\n",
diff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h
index 4679d94..edf96de 100644
--- a/lib/ethdev/rte_ethdev_core.h
+++ b/lib/ethdev/rte_ethdev_core.h
@@ -167,7 +167,11 @@ struct rte_eth_dev_data {
scattered_rx : 1, /**< RX of scattered packets is ON(1) / OFF(0) */
all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */
dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */
- lro : 1; /**< RX LRO is ON(1) / OFF(0) */
+ lro : 1, /**< RX LRO is ON(1) / OFF(0) */
+ dev_configured : 1;
+ /**< Indicates whether the device is configured.
+ * CONFIGURED(1) / NOT CONFIGURED(0).
+ */
uint8_t rx_queue_state[RTE_MAX_QUEUES_PER_PORT];
/**< Queues state: HAIRPIN(2) / STARTED(1) / STOPPED(0). */
uint8_t tx_queue_state[RTE_MAX_QUEUES_PER_PORT];
--
2.7.4
next prev parent reply other threads:[~2021-07-06 4:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 8:00 [dpdk-dev] [RFC] lib/ethdev: " Huisong Li
2021-05-31 8:51 ` Huisong Li
2021-06-14 15:37 ` Andrew Rybchenko
2021-06-29 2:27 ` Huisong Li
2021-07-02 10:08 ` Andrew Rybchenko
2021-07-02 11:57 ` Ferruh Yigit
2021-07-02 13:23 ` Ananyev, Konstantin
2021-07-03 8:35 ` Huisong Li
2021-07-03 11:04 ` Ananyev, Konstantin
2021-07-05 3:03 ` Huisong Li
2021-07-05 9:50 ` Andrew Rybchenko
2021-07-05 11:22 ` Ananyev, Konstantin
2021-07-06 1:47 ` Huisong Li
2021-07-04 20:05 ` Thomas Monjalon
2021-07-05 3:18 ` Huisong Li
2021-07-05 6:07 ` Thomas Monjalon
2021-07-05 9:50 ` Andrew Rybchenko
2021-07-06 1:48 ` Huisong Li
2021-07-06 3:24 ` [dpdk-dev] [PATCH V1] ethdev: " Huisong Li
2021-07-06 4:10 ` Huisong Li [this message]
2021-07-06 8:36 ` [dpdk-dev] [PATCH V2] " Andrew Rybchenko
2021-07-07 2:55 ` Huisong Li
2021-07-07 8:25 ` Andrew Rybchenko
2021-07-07 9:26 ` Huisong Li
2021-07-07 7:39 ` David Marchand
2021-07-07 8:23 ` Andrew Rybchenko
2021-07-07 9:36 ` David Marchand
2021-07-07 9:59 ` Thomas Monjalon
2021-07-07 10:40 ` David Marchand
2021-07-07 10:57 ` Thomas Monjalon
2021-07-06 17:49 ` Ananyev, Konstantin
2021-07-07 9:53 ` [dpdk-dev] [PATCH V3] " Huisong Li
2021-07-08 9:56 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625544608-30590-1-git-send-email-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).