From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 2459537AF
 for <dev@dpdk.org>; Mon,  2 Nov 2015 09:12:23 +0100 (CET)
Received: by wmeg8 with SMTP id g8so52023773wme.0
 for <dev@dpdk.org>; Mon, 02 Nov 2015 00:12:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind_com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=DNglo8eJROGzpSkkE3j7ATBmNbFVT7exR8y8v8SYIbs=;
 b=DpPx9HlK+D/Of4jydDV2CDEgsipioMB6SevFQ4KQL8GrcH63RfNanDled78ONg3M4f
 Vq9vE+60ddiQC3cYMMcEWCj2km8lrZbj/H4QJQKdxysLth7gi9nfquhjcFNdgvdd2ijc
 KmHbzNqfUL1vUgrtbN3n71mWCdh0wNIPD0kkXoyruJZmM17BY8gyuX8zcnmJ/wCg85tw
 VrOb11EIRvE8LG/1uFPeyy1U3+dDpuwYm2Sm+SbFyQHk3QBHR4gFj291c+ibcsxJJsSF
 vbZBmVEYEfW+xbOP8GMxJ3Lz2R7mWLsper5ZfhsoqQkQ2CmyLa4sZM9q7OBfWGerWco5
 gu3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=DNglo8eJROGzpSkkE3j7ATBmNbFVT7exR8y8v8SYIbs=;
 b=k2hiqj0wrQbyh7mefuFkRweTIAzFfmuSZPwWwwV5wisACtIY88Hzd7Umd0P7eN0spw
 RWw3c+VG0X91pjQEw+/UGf0ZXza15O+kQ9fMkzV9vIlH28pIJimt7lIKrQnYG3BDgTyH
 JK+8XM1YEzK2HXegMHrguYSRWRX4S7JWvSssDI3ZKjWUHl8HXFvewiOLfwZpu6qeQcfK
 /Fp0+8xdFUIhFySZibdZxdKlOWrrkZanxUcvYyTLQWfvEVZwmmB6IO0d6KYv+TuvrcJ1
 lDU9LfwmIMiOOX9HfhNsrYNiovRS9lfEE4j5bF393+X3GkNVPj24cRI+mR55fZpfAodM
 K5PA==
X-Gm-Message-State: ALoCoQmPmPJ6w/0E3HnIUAx/9p0ygA5XVlPLXPpHGtpbfbY4YP478aJARRgTW4KiwZxt6fIZVEV/
X-Received: by 10.28.170.196 with SMTP id t187mr12949135wme.1.1446451942978;
 Mon, 02 Nov 2015 00:12:22 -0800 (PST)
Received: from xps13.localnet (144.16.90.92.rev.sfr.net. [92.90.16.144])
 by smtp.gmail.com with ESMTPSA id v191sm16681814wmd.24.2015.11.02.00.12.19
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 02 Nov 2015 00:12:22 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Date: Mon, 02 Nov 2015 08:59:26 +0100
Message-ID: <1625667.g6rLv7AGl4@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1446204998-17151-3-git-send-email-harry.van.haaren@intel.com>
References: <1445528914-27636-2-git-send-email-harry.van.haaren@intel.com>
 <1446204998-17151-1-git-send-email-harry.van.haaren@intel.com>
 <1446204998-17151-3-git-send-email-harry.van.haaren@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 02/10] ethdev: update xstats_get() strings
	and Q handling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 08:12:23 -0000

2015-10-30 11:36, Harry van Haaren:
> +       /* if xstats_get() is implemented by the PMD, the Q stats are done */
> +       if (dev->dev_ops->xstats_get != NULL)
> +               return count + xcount;
> +
>         /* per-rxq stats */
>         for (q = 0; q < dev->data->nb_rx_queues; q++) {
>                 for (i = 0; i < RTE_NB_RXQ_STATS; i++) {

Please could you explain why the generic per-queue stats are not used when
xstats is implemented in the driver?