From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 693EDA052A; Fri, 10 Jul 2020 23:11:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2012F1D9F4; Fri, 10 Jul 2020 23:11:38 +0200 (CEST) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by dpdk.org (Postfix) with ESMTP id 3AC861D9F3; Fri, 10 Jul 2020 23:11:36 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 8462C13D1; Fri, 10 Jul 2020 17:11:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 10 Jul 2020 17:11:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= kKYk5g9ZM8SSLWgpoJx0fO5bk3vyTXfE1sfTF1s2mdM=; b=w3PdS35k50KiDF1p vn69vuG2tXtgTWUODL/gPG7v+6aihPddoXSNLLGVbXinxqbuCdMpK/WKtzxd3B0f 29qkAeUhhSKa+87ut1P27eqUpTGD9Vzhky8Y1vEMAj1Tbou2MYBFq77x2kf3AsiI PMKDalWRwJbj0SlUyv3jvOTUu2RrHNUX2ekn6FDclYESfIyLQiPbv15Q0K03GR84 LtF1TWcTRepem6tuPG+HbupHIAEuIfMOGwl+VfSn6pMdi9kzYeMHzKgvLehsw7qv VISzO/sPftLQ5n24i0eVbVx0CTRvElF8VrjPg0o2bGg/1mmxoc/pdi+zvXR8/7Dh XsQRnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=kKYk5g9ZM8SSLWgpoJx0fO5bk3vyTXfE1sfTF1s2m dM=; b=Y2U+Wum4fPbmmu996NyZRvnCfmVNymNMCSVlRE+62R5oy9S0etNTphd16 oYMAA7LIkJDfjiE3KlH+6W1P17s8Rw4+1Xrf2Qqw8iGo8QlJqGLL6Rg2zzdIPPbo BpnDTRhV18RV86MJWVJBtcda2id+8kOtZwLvB/Cg9/76iNN6kHWPQrctGsMYLD2J TssECSK0rNhcJkuvS2H/ssVVJyJUOp57lU/Jr+2P9cpQp1Pn1/jG+CELL2HfJj2z E41okYNZSIjR2eiWnno3phe7iomq0TiJTTWJl3dHSfhErcglktwYSvtXWXPjLB8z t0uvX3MZR0DY5whLvmVxxg7B4P/aw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddugdduieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2C59E30600B2; Fri, 10 Jul 2020 17:11:32 -0400 (EDT) From: Thomas Monjalon To: Hongzhi Guo Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= , stable@dpdk.org, dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org, konstantin.ananyev@intel.com, ferruh.yigit@intel.com, nicolas.chautru@intel.com, zhoujingbin@huawei.com, chenchanghu@huawei.com, jerry.lilijun@huawei.com, haifeng.lin@huawei.com Date: Fri, 10 Jul 2020 23:11:31 +0200 Message-ID: <1625950.jeTQybBuoM@thomas> In-Reply-To: <20200710123722.GX5869@platinum> References: <20200710114313.7412-1-guohongzhi1@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35C61117@smartserver.smartshare.dk> <20200710123722.GX5869@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix checksum on big endian CPUs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/07/2020 14:37, Olivier Matz: > On Fri, Jul 10, 2020 at 02:20:08PM +0200, Morten Br=F8rup wrote: > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hongzhi Guo > > > Sent: Friday, July 10, 2020 1:43 PM > > >=20 > > > With current code, the checksum of odd-length buffers is wrong on > > > big endian CPUs: the last byte is not properly summed to the > > > accumulator. > > >=20 > > > Fix this by left-shifting the remaining byte by 8. For instance, > > > if the last byte is 0x42, we should add 0x4200 to the accumulator > > > on big endian CPUs. > > >=20 > > > This change is similar to what is suggested in Errata 3133 of > > > RFC 1071. > > >=20 > > > Fixes: 6006818cfb26("net: new checksum functions") > > > Cc: stable@dpdk.org > > >=20 > > > Signed-off-by: Hongzhi Guo > >=20 > > Reviewed-by: Morten Br=F8rup >=20 > Acked-by: Olivier Matz Applied, thank you Hongzhi Guo, we want more patches like this :-)