From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 1BE73376C for ; Wed, 3 Jun 2015 19:36:26 +0200 (CEST) Received: by wibdt2 with SMTP id dt2so21752563wib.1 for ; Wed, 03 Jun 2015 10:36:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=sSmHsCqRmgLkmRoLsmU+NaMlQ1KgARrtJKwZbzMrjZU=; b=DW4eo0PticdrVcp81bisnajgIp4R4sevx9TfAM73nZJkaH9n7Yf2x0EfdcYNMH0xtu rwzoITMw1ofXylrDFnlg1BIORCUgXYwd/7Hkd3TNuILzdacKwLgX1WH+yIHloSuXgRM6 Sk4qiXCDIw2bfr+CfCQ1MflJN5gc0cymF2U2O66hEfW7MQC/qr++fiU41ba8xPsaz1ST 1fhquxny6ih8SEbvmtGswD4HRygtVSleydCbMjnyFUAy4+BUFn/t4+017vH7At98PJhP mBZYG5uV60fkpR9t27KrV70FdnESAo8ZcwIuR0UmThg9D2bV0PY5xT08srcQFzk1D6xH cQsQ== X-Gm-Message-State: ALoCoQlAZxRgYVkQ0lhaD5IiHsRPvWMKJsfusULxATfH+kShp4i4oj74KP8i3WCjF1w0nwPYwB8M X-Received: by 10.194.235.4 with SMTP id ui4mr63927023wjc.0.1433352985910; Wed, 03 Jun 2015 10:36:25 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u6sm2033898wja.40.2015.06.03.10.36.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 10:36:23 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 03 Jun 2015 19:35:32 +0200 Message-ID: <1627508.1SMo23WCxz@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1433339893-19603-1-git-send-email-bruce.richardson@intel.com> References: <1431531022-29697-2-git-send-email-bruce.richardson@intel.com> <1433339893-19603-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] doc: add coding standards documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2015 17:36:26 -0000 2015-06-03 14:58, Bruce Richardson: > Add coding standards document to guides directory. This document > codifies the current DPDK C coding conventions, to make it easier for > contributors to see the format their code should be in. > > Signed-off-by: Siobhan Butler > Signed-off-by: Bruce Richardson > > --- > > Updates in V2: > * Fixed file creation mode > * Removed blank line at end of file > * Adjusted coding blocks to be C language, rather than console, so as to > have correct syntax highlighting. > * Shortened longer lines by breaking lines at sentence - and > occasionally comma - boundaries. > --- > doc/guides/coding_standards/index.rst | 861 ++++++++++++++++++++++++++++++++++ > doc/guides/index.rst | 1 + This version seems very good. However, I have the feeling that coding_standards/ is not a good name: - "standards" word is a bit strong ; - "coding" seems too restrictive, maybe we would like to put more guidelines in this directory (thinking about file tree, compat and tests). Do you agree I rename it to guidelines/coding_style.rst?