From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
Cc: <matan@nvidia.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Ray Kinsella" <mdr@ashroe.eu>,
Stephen Hemminger <sthemmin@microsoft.com>,
Long Li <longli@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable
Date: Thu, 28 Oct 2021 11:22:59 +0100 [thread overview]
Message-ID: <1628c943-58b6-12ff-9827-dc493420e074@intel.com> (raw)
In-Reply-To: <20211028083457.3024272-1-thomas@monjalon.net>
On 10/28/2021 9:34 AM, Thomas Monjalon wrote:
> The port ownership concept was introduced in ethdev in DPDK 18.02.
> Not sure it is used by applications except those using failsafe or netvsc.
> It can also be used by libraries or applications to sort out
> how ports are controlled.
>
> Hiding sub-ports controlled by failsafe or netvsc look to be enough
> justification to promote this API as stable.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
There is a defect in the 'rte_eth_dev_owner_delete()', which cause a crash,
it is fixed in my ethdev unit test patch:
https://patches.dpdk.org/project/dpdk/patch/20210716142800.3853651-8-ferruh.yigit@intel.com/
I think we should get the fix first.
And the crash not detected/reported until now makes me think API is still
not used much, I wonder if we should wait a little more to mature them.
Also only internal user of the API is 'drivers/net/netvsc', I wonder if
PMD detect the crash?
next prev parent reply other threads:[~2021-10-28 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 8:34 Thomas Monjalon
2021-10-28 8:37 ` Kinsella, Ray
2021-10-28 8:55 ` Andrew Rybchenko
2022-06-02 11:43 ` Ferruh Yigit
2021-10-28 10:22 ` Ferruh Yigit [this message]
2021-10-28 10:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628c943-58b6-12ff-9827-dc493420e074@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).