From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9789A0550; Sun, 16 Feb 2020 19:10:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 427C61BFF8; Sun, 16 Feb 2020 19:10:33 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 0BDD61BFF7; Sun, 16 Feb 2020 19:10:31 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 752EB68F; Sun, 16 Feb 2020 13:10:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 16 Feb 2020 13:10:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=eY6VCa7hZr39jOmIMjg+1BDeVuTzNMblUbtegYb8f44=; b=J4w80IwTXBoK gCkvvIusMGRUitTmSh3aEc4LmmyU4BgkuMy4FaacYppv94vny58tZ9W3SueLL47g o1Cxx5w7us5Vo4HZ7YYubI4LNecSImj6GV7oHrbvdAQb3Q2yi6HrzFK2tLgiRpN7 yYiwT6JJm1SFV/3JJlasACAp5VvbnRI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eY6VCa7hZr39jOmIMjg+1BDeVuTzNMblUbtegYb8f 44=; b=op/u1u09zB7jg5qmi3E+1tUFGgzTHmLQ1ILWXpz7fCIa8biwen/X/bZaB vvX/A8Zydsya4/Awpw7Zn3/vpl4Kg9ZucEtBMk9Q0Hchx/W+j+l5SpmOJaGKHc3l ZmO0L4V0Dte99zdID2NPi8C1DTLp9G0UCuYP03P2dWLKrX0DdKAjBS5DL3cVdxfI 2lS7v8EdwuTa/wpb1Deh12kcdmYyVlGzCJxBwSPVAukr2cxwdev0XhTP62TQzhJv aF6Q3lblvn2pVbGF+jX2pS9JAM9OnsAsv8HGzsku1Y1U7ij1984tqCwB2tK7UJX1 SkoRCozNqRwkks0Wazhcp3o/BZO/w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeggddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehtrhgrvhhishdqtghirdgtohhmnecukfhppeejjedrudefgedrvddtfedr udekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 600A3328005E; Sun, 16 Feb 2020 13:10:27 -0500 (EST) From: Thomas Monjalon To: Reshma Pattan , Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Nikhil Rao , Chas Williams , Stephen Hemminger Date: Sun, 16 Feb 2020 19:10:25 +0100 Message-ID: <16308966.lhrHg4fidi@xps> In-Reply-To: <20200120173609.GA1743@bricha3-MOBL.ger.corp.intel.com> References: <20191218115831.4035-1-reshma.pattan@intel.com> <20191223065305.18434-1-reshma.pattan@intel.com> <20200120173609.GA1743@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/01/2020 18:36, Bruce Richardson: > On Mon, Dec 23, 2019 at 06:53:05AM +0000, Reshma Pattan wrote: > > Some unit tests has dependency on RING PMD, > > so this patch is trying to fix those and other > > closely related issues. > > > > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter > > unit tests are dependent on ring PMD, so compile those > > tests only when ring PMD is enabled else ignore. > > > > 2)get rid of make file error which was added by bond unit test > > for ring PMD disabled case which is not necessary. > > > > 3)Tx adapter UT is dependent on RING PMD, but it was > > observed that it was missing from the run in meson > > build, so added it. TX adapter UT uses 'sw event and > > 'null' pmd drivers, so for shared builds the drivers .so > > path has to be passed to the test args of meson UT run. > > > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") > > Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library") > > Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats library") > > Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter") > > Fixes: d23e09e0ef ("app/test: link with ring pmd when needed") > > > > CC: stable@dpdk.org > > CC: Nikhil Rao > > CC: Chas Williams > > CC: Bruce Richardson > > CC: Stephen Hemminger > > > > Reported-by: Stephen Hemminger > > Signed-off-by: Reshma Pattan > > --- > > v5: remove extra blank line. > > v4: fix event_eth_tx_adapter_autotest for shared build > > as reported by travis-ci > > https://travis-ci.com/ovsrobot/dpdk/jobs/249598391 > > v3: add missing test event_eth_tx_adapter_autotest. > > Add link bonding mode4 test to drivers test. > > v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1 > > --- > > Confirmed build now works with disable_drivers=net/ring > > Tested-by: Bruce Richardson Applied, thanks > Unfortunately, other parts fail if other drivers are similarly disabled, > but that is for another patchset (and probably release!) to fix. Good to know we are far from retirement ;)