DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Larry Wang <liang-min.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test: fix misplaced braces in strncmp call
Date: Mon, 24 Nov 2014 16:54:34 +0100	[thread overview]
Message-ID: <16317398.W5JJMvBuqs@xps13> (raw)
In-Reply-To: <546C6EF3.1080507@6wind.com>

> > This patch fixes two occurances where a call to strncmp had the closing
> > brace in the wrong place. Changing this form:
> > 	if (strncmp(X,Y,sizeof(X) != 0))
> > which does a comparison of length 1, to
> > 	if (strncmp(X,Y,sizeof(X)) != 0)
> > which does the correct length comparison and then compares the result to
> > zero in the "if" part, as the author presumably originally intended.
> >
> > Reported-by: Larry Wang <liang-min.wang@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Nice catch!
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
 
Applied

Thanks
-- 
Thomas

      reply	other threads:[~2014-11-24 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  9:06 Bruce Richardson
2014-11-19 10:20 ` Olivier MATZ
2014-11-24 15:54   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16317398.W5JJMvBuqs@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=liang-min.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).