From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 22A0D80A4 for ; Mon, 24 Nov 2014 16:44:10 +0100 (CET) Received: by mail-wg0-f51.google.com with SMTP id k14so12469441wgh.38 for ; Mon, 24 Nov 2014 07:54:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9GydKAoZgFInXlI87m+5k8+1NtPHKIy9optX1Z8wVkk=; b=nGUx5jlapBUmmfNpfSoNMK14xsTZldN+ahaOChGU2pAiHQK2PLcdgOKp2XzXOMB+SL wlQwp2pFbIBFfF/l143jThG6tMonT2b+bWKrGPYyvc1joOrloTu8z/8fCGew3f5ZvuUc T+TzAJpStjEhw/LjVsQ8R2TVYxyt70e89ruFipdj4pj4SbxvAWe2mqyiJ63P4N0Us5HM kCjCb0mePeUCwNTgWBhjJonReeTH6LuzmUdjtpC64SqBHWVHY3Iv+CfwuVa6BweTIEpm 7kX0Xn2heD24NmxWAtyCEXjf587LxZfghX0VMRomr6A63fdyXBbQm/MCesNpCfQEbC4n PWrQ== X-Gm-Message-State: ALoCoQn+jn26aaApJlwLMZ33N0tJqgcayN0A3cbJO6Eiy7mRDzyZCu8Zu9rn8VZhZq8TjTzRtkmY X-Received: by 10.180.96.162 with SMTP id dt2mr23231164wib.66.1416844498527; Mon, 24 Nov 2014 07:54:58 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id w4sm21546540wjw.39.2014.11.24.07.54.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Nov 2014 07:54:57 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Mon, 24 Nov 2014 16:54:34 +0100 Message-ID: <16317398.W5JJMvBuqs@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <546C6EF3.1080507@6wind.com> References: <1416387973-28431-1-git-send-email-bruce.richardson@intel.com> <546C6EF3.1080507@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Larry Wang Subject: Re: [dpdk-dev] [PATCH] test: fix misplaced braces in strncmp call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2014 15:44:10 -0000 > > This patch fixes two occurances where a call to strncmp had the closing > > brace in the wrong place. Changing this form: > > if (strncmp(X,Y,sizeof(X) != 0)) > > which does a comparison of length 1, to > > if (strncmp(X,Y,sizeof(X)) != 0) > > which does the correct length comparison and then compares the result to > > zero in the "if" part, as the author presumably originally intended. > > > > Reported-by: Larry Wang > > Signed-off-by: Bruce Richardson > > Nice catch! > > Acked-by: Olivier Matz Applied Thanks -- Thomas