From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 822A02A5F for ; Fri, 5 Jun 2015 12:31:28 +0200 (CEST) Received: by wgme6 with SMTP id e6so53343143wgm.2 for ; Fri, 05 Jun 2015 03:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=NwyHlOw3JPk5D24DYs7ef8FinTWJsdvxBmxuHwauRNs=; b=CrjSU/KJwAuIN8KWjd8UJCfLr8Bzst7VO0/uY8FFzvmTjJUp++bKEp9Fe4jzfiS82a ExSMMt0LdEBVWJReNaXKvloPoLMOXcDHU7JMlQXULX5ciekamyvgwdh4WZWHyFk6tGP7 rfXzyohHACBx9XtmB9mQYzhO1z9Tg1MnclVwTjBcID5TNX7zT2WKTGRvA4L/14D+oruV tSwKt24ebYFMVJVubFn9PHCzMK+CQ7eHGwn518Zt6YTrpkv81QVL0mxQFtOEgU4Bj5nb phSk3PrjkvMp//Cd8OG8JraSnninqb9Wn1eIoNcF8LzJlncPSNOEkXckWWUs/5VHCh3Z g0Sw== X-Gm-Message-State: ALoCoQmYl9ff0UXulcV1Zyol7canejVascSDJDQhB8mZLsWTAB3gEsyuLRaMcoiJCmemCAqbx6MW X-Received: by 10.194.200.73 with SMTP id jq9mr5302099wjc.52.1433500288381; Fri, 05 Jun 2015 03:31:28 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id y19sm2621372wia.15.2015.06.05.03.31.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 03:31:27 -0700 (PDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" Date: Fri, 05 Jun 2015 12:30:35 +0200 Message-ID: <1633235.huhZUFEmyt@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263236E6CA@IRSMSX108.ger.corp.intel.com> References: <3EB4FA525960D640B5BDFFD6A3D891263236E6CA@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Rajagopalan Sivaramakrishnan Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2015 10:31:28 -0000 2015-05-28 19:26, Dumitrescu, Cristian: > I think we have the following options identified so far for stats collection configuration: > > 1. Stats configuration through the RTE_LOG_LEVEL > 2. Single configuration flag global for all DPDK libraries > 3. Single configuration flag per DPDK library > > It would be good if Thomas and Stephen, as well as others, would reply with their preference order. There are important design questions in these threads. I think that the best way to come to a conclusion is to submit a design rule - to state whether statistics must be considered as a feature or as debug, - and to decide whether stats must be always available or disabled globally or per-library. It should be written in a new doc. I suggest docs/guidelines/design.rst. Then we'll have to discuss and vote on this base. It will avoid future discussions. The underlying discussion is to decide if every cycle is important even if there is a real usability drawback. In order to reach a conclusion, it seems reasonnable to target a consensus 2 weeks after the first submission of these design rules. Thanks Cristian to follow up.