DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ethdev: fix port accessing after release
@ 2018-03-28 12:10 Matan Azrad
  2018-03-28 12:25 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2018-03-28 12:10 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Ferruh Yigit, stable

rte_eth_dev_pci_release() function wrongly releases an ethdev port and
then releases internal fields of this port.
This behavior is problematic, because after the release, the port may
be reallocated again by another thread or just be invalid for any
usage.

Move the release operation to the end of the function.

Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
Cc: stable@dpdk.org

Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
 lib/librte_ether/rte_ethdev_pci.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h
index 897ce5b..6565ae7 100644
--- a/lib/librte_ether/rte_ethdev_pci.h
+++ b/lib/librte_ether/rte_ethdev_pci.h
@@ -123,9 +123,6 @@
 static inline void
 rte_eth_dev_pci_release(struct rte_eth_dev *eth_dev)
 {
-	/* free ether device */
-	rte_eth_dev_release_port(eth_dev);
-
 	if (rte_eal_process_type() == RTE_PROC_PRIMARY)
 		rte_free(eth_dev->data->dev_private);
 
@@ -139,6 +136,9 @@
 
 	eth_dev->device = NULL;
 	eth_dev->intr_handle = NULL;
+
+	/* free ether device */
+	rte_eth_dev_release_port(eth_dev);
 }
 
 typedef int (*eth_dev_pci_callback_t)(struct rte_eth_dev *eth_dev);
-- 
1.9.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: fix port accessing after release
  2018-03-28 12:10 [dpdk-dev] [PATCH] ethdev: fix port accessing after release Matan Azrad
@ 2018-03-28 12:25 ` Thomas Monjalon
  2018-03-30 10:40   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2018-03-28 12:25 UTC (permalink / raw)
  To: Matan Azrad; +Cc: dev, Ferruh Yigit, stable

28/03/2018 14:10, Matan Azrad:
> rte_eth_dev_pci_release() function wrongly releases an ethdev port and
> then releases internal fields of this port.
> This behavior is problematic, because after the release, the port may
> be reallocated again by another thread or just be invalid for any
> usage.
> 
> Move the release operation to the end of the function.
> 
> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
> Cc: stable@dpdk.org
> 
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Matan Azrad <matan@mellanox.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: fix port accessing after release
  2018-03-28 12:25 ` Thomas Monjalon
@ 2018-03-30 10:40   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-03-30 10:40 UTC (permalink / raw)
  To: Thomas Monjalon, Matan Azrad; +Cc: dev, stable

On 3/28/2018 1:25 PM, Thomas Monjalon wrote:
> 28/03/2018 14:10, Matan Azrad:
>> rte_eth_dev_pci_release() function wrongly releases an ethdev port and
>> then releases internal fields of this port.
>> This behavior is problematic, because after the release, the port may
>> be reallocated again by another thread or just be invalid for any
>> usage.
>>
>> Move the release operation to the end of the function.
>>
>> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
>> Cc: stable@dpdk.org
>>
>> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-30 10:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-28 12:10 [dpdk-dev] [PATCH] ethdev: fix port accessing after release Matan Azrad
2018-03-28 12:25 ` Thomas Monjalon
2018-03-30 10:40   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).