From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AC0DA04DB; Thu, 15 Oct 2020 01:16:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F0201DA68; Thu, 15 Oct 2020 01:16:35 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A851D1DA67 for ; Thu, 15 Oct 2020 01:16:32 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 4ACB65C0182; Wed, 14 Oct 2020 19:16:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Oct 2020 19:16:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= inn+DX/FpUtSKu0xIwEJiqpXxwqq7fNsXFNbUNo1nmo=; b=nr6w7WkMg7ICONXf ZU4/+Xg3mGl8qMGVNeJz7YJdkKIs3gcRKo+k3U3KOisCHaffSY/GxUaLUs+UEqme FO6dLJQBfoM2g4c3xclvG2o502ZlTGGeaLN8Yy1nq1Z8s8vpRyaX8kJOl4Lk8+xX D27W209trKByi81aSX59C4mHRb4wSPsUVhas51fp4no9LQgbxSbdSXrhyhH9RdKW Li00RQQtBTDWJo+7YUzdjBE+hj0yjf2L1FIeqk1m5bxAkvQGavCsCqOE+Eb7BdGG G0dXCk4cSpxrBOkfNdSGCAhX7wkSIPm8iFeeCIJHf/YUR0uNkLi7/ZHF71Kq8Mp6 YQp/NQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=inn+DX/FpUtSKu0xIwEJiqpXxwqq7fNsXFNbUNo1n mo=; b=E6zsP0+lcEzwfe3spiYW4UfxnRfXiWk9qPxtTwGzN5WBmqGA2UZDWPlFO qGVhiiyJzO1m3izF2YrTWS0onLHE62/0sdqdcFh5z7Pu9qsB8EYtD2G2OQsYKoAR PlNT6dKdf8FpLACcOH4HgqjVbqpLKofyOJV0sbCybDzdNVkjr38nFQdRrtccqrCa LrcBgpcBnS6pX7eJUUO7smdvbdm/GuG4ygdwzX6TND2JqYsqC8TSdY3Myu2nDmcV KATc9kEpmkzOje6fX9tcRCkpustA6WsqEyMPsRyaeFlgNyo5wJ+JgY5qASwyQr7D bNQG3egnK4OdZU/neKM7zDHz0H2Xw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedriedvgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B52E306467D; Wed, 14 Oct 2020 19:16:30 -0400 (EDT) From: Thomas Monjalon To: Eli Britstein Cc: dev@dpdk.org, david.marchand@redhat.com Date: Thu, 15 Oct 2020 01:16:29 +0200 Message-ID: <1634944.yJlA45dGKM@thomas> In-Reply-To: <20201014061909.9957-1-elibr@nvidia.com> References: <20201014061909.9957-1-elibr@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix build with conflicting libc variable memory_order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/10/2020 08:19, Eli Britstein: > The cited commit introduced functions with 'int memory_order' argument. > The C11 standard section 7.17.1.4 defines 'memory_order' as the > "enumerated type whose enumerators identify memory ordering constraints". > Applications that use the standard enum (includes stdatomic.h), will > fail compilation with: > error: declaration of 'memory_order' shadows a global declaration > [-Werror=shadow] > rte_atomic_thread_fence(int memory_order) > Fix it by changing the argument name 'memory_order' to 'memorder'. Not clear why it builds fine with most compilers, but the fix does not hurt. > Fixes: 672a15056380 ("eal: add wrapper for C11 atomic thread fence") A blank line should be inserted here. > Signed-off-by: Eli Britstein Acked-by: Thomas Monjalon