From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0B9C11B3CF for ; Sun, 15 Apr 2018 19:35:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 546BD21B94; Sun, 15 Apr 2018 13:35:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 15 Apr 2018 13:35:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=qyX7oF3DGwsVh1KPts1mizL5KH MC6InMaQmPbPq5d4c=; b=dpseGPpmkayqitSEf246ERz6Yv6kM6ENhvWKVuwwBx x8Hu3/Yt2ZI22Mcij2veF5yDRktceaPL4hFdNDFMUifcZDVOMOQSBFJ+RwXxxXV6 DpEDZZqKZKVSTKo+T3Gkh/ZBYddP2+/80A44RnpZfANsgpd/JVBvp57HU26Ogmo/ I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=qyX7oF 3DGwsVh1KPts1mizL5KHMC6InMaQmPbPq5d4c=; b=Yq/8vRNV+qlAKqKJrLPq8H N8HXgOmohsgPakFvfiNKPYPOcqR1afEChX1zAmpCNgPtKa28K+bjKxwO6TkFaySc f35N5hPcnTvLQx28d7beL3aEL2U2Cjft1EIrLvoGCZnwJ09pIw2t6Zxiwk+jEZHy lt4PWTDWfrGSquxc8a3Q88gNZ/Y3Zys+boRybFW/SMMXGdlvKAXWScrjq/suavbn zdAJvMVKQb46vulFvJmySUQJvuGuS73lZ/gBQfbRe3f3ua8MtZv5B5TfFQvVV4sF dxgmiov2oqcDjPs8AWb9TToElRw3uXSMI638PkYciTjLWPdWbW9csoIVXkIkiWPg == X-ME-Sender: Received: from xps.localnet (59.15.136.77.rev.sfr.net [77.136.15.59]) by mail.messagingengine.com (Postfix) with ESMTPA id 823DFE46C2; Sun, 15 Apr 2018 13:35:18 -0400 (EDT) From: Thomas Monjalon To: Fan Zhang , ferruh.yigit@intel.com, maxime.coquelin@redhat.com Cc: dev@dpdk.org, jianjay.zhou@huawei.com, jianfeng.tan@intel.com, pawelx.wodkowski@intel.com Date: Sun, 15 Apr 2018 19:35:14 +0200 Message-ID: <1635741.7WSiDOFoul@xps> In-Reply-To: <1845545.r90AWaGVlL@xps> References: <20180404142504.31836-1-roy.fan.zhang@intel.com> <20180405160137.56413-8-roy.fan.zhang@intel.com> <1845545.r90AWaGVlL@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 7/8] examples/vhost_crypto: add vhost crypto sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Apr 2018 17:35:23 -0000 15/04/2018 16:34, Thomas Monjalon: > Hi, > > 05/04/2018 18:01, Fan Zhang: > > This patch adds vhost_crypto sample application to DPDK. > > > > Signed-off-by: Fan Zhang > > --- > > examples/vhost_crypto/Makefile | 32 +++ > > examples/vhost_crypto/main.c | 541 ++++++++++++++++++++++++++++++++++++++ > > examples/vhost_crypto/meson.build | 14 + > > 3 files changed, 587 insertions(+) > > There are 3 misses: > > - not in examples/Makefile > - not in MAINTAINERS > - no documentation in doc/guides/sample_app_ug/ > > It won't be accepted in master as-is. The doc is (curiously) in the next patch. I will move it here. I will also fix the Makefile and the MAINTAINERS file: ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_crypto endif Vhost-user M: Maxime Coquelin M: Jianfeng Tan T: git://dpdk.org/next/dpdk-next-virtio F: lib/librte_vhost/ [...] F: examples/vhost_crypto/ Ferruh, Maxime, I hope you agree with this last-minute fix.