From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23E27A0C52; Mon, 1 Nov 2021 08:29:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A31B840E28; Mon, 1 Nov 2021 08:29:24 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 92C6B40DF6 for ; Mon, 1 Nov 2021 08:29:22 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 19VLwEcX018888 for ; Mon, 1 Nov 2021 00:29:21 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=4iGW/b9HsmE0EqdkTcD8UWWufTmM6TzewJ+OJRIbxP0=; b=SQjYEERnZFb8jqY7LbQdV4OBqyfFOP+vqZZ8fxbXT0gqPySuYUo66eKCblIZC+qU1/vr qe7fTeTtdoiw1drdaR9Mx8Zw5aTlkmw5B9vtCsAWB50ZSuBmMcX7UGeRnMNeDHuXj5Nl 7GM1LKZEysZBi06CXUOAiJM3uSa1YB/Xb9fHIRqL7W+2Bqs60kNhA2pgJqd4+13/MgAb 5ecLQXjq/goUQA4vvnP31vEDMSlx56Sfs+NL8p7+fV+XB83akzMYTQ5FXvm8VIkemosn dw/3kZx2afLfhNs8Jnb/pvtFJ3oGD90b2aheUXbvMVVMn/WqgrhkS8Nbm2jaQi6mUDEX uA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3c1vk3ahd7-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 01 Nov 2021 00:29:21 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 1 Nov 2021 00:29:18 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Mon, 1 Nov 2021 00:29:18 -0700 Received: from cavium.localdomain (unknown [10.28.34.26]) by maili.marvell.com (Postfix) with ESMTP id 241F15B6952; Mon, 1 Nov 2021 00:29:16 -0700 (PDT) From: To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: Date: Mon, 1 Nov 2021 03:28:57 -0400 Message-ID: <1635751737-29259-1-git-send-email-skoteshwar@marvell.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-ORIG-GUID: wVeMd8xEW4XFmn_8XUATVQPjR2vedd6e X-Proofpoint-GUID: wVeMd8xEW4XFmn_8XUATVQPjR2vedd6e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-01_03,2021-10-29_03,2020-04-07_01 Subject: [dpdk-dev] [PATCH] common/cnxk: consider adjust value for tm burst calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Satha Rao To support lower pps in packet mode we are changing adjust value, same needs to be consider for burst size calculations. When both peak and committed rates requested, then peak rate should be larger than committed rate. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_tm_ops.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index eee80d5..b80c77c 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -124,6 +124,11 @@ profile->pkt_mode_adj += adjust; profile->commit.rate += (adjust * profile->commit.rate); profile->peak.rate += (adjust * profile->peak.rate); + /* Number of tokens freed after scheduling was proportional + * to adjust value + */ + profile->commit.size *= adjust; + profile->peak.size *= adjust; } return 0; @@ -181,6 +186,10 @@ return NIX_ERR_TM_INVALID_PEAK_RATE; } + /* If PIR and CIR are requested, PIR should always be larger than CIR */ + if (peak_rate && commit_rate && (commit_rate > peak_rate)) + return NIX_ERR_TM_INVALID_PEAK_RATE; + if (!skip_ins) TAILQ_INSERT_TAIL(&nix->shaper_profile_list, profile, shaper); -- 1.8.3.1