DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH -v1] Update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
@ 2021-11-17  1:55 Zhang, Mingshan
  2021-11-17  1:55 ` [PATCH -v1] bbdev: update " Zhang, Mingshan
  0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Mingshan @ 2021-11-17  1:55 UTC (permalink / raw)
  To: dev, akhil.goyal; +Cc: nicolas.chautru, Zhang, Mingshan

From: "Zhang, Mingshan" <mingshan.zhang@intel.com>

Update num_ops type from uint16_t to uint32_t in rte_bbdev_enc_op_alloc_bulk to enlarge the input range.

Mingshan Zhang (1):
  bbdev: update num_ops type to be uint32_t in
    rte_bbdev_enc_op_alloc_bulk

 doc/guides/prog_guide/bbdev.rst | 4 ++--
 lib/bbdev/rte_bbdev_op.h        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH -v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
  2021-11-17  1:55 [PATCH -v1] Update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk Zhang, Mingshan
@ 2021-11-17  1:55 ` Zhang, Mingshan
  2021-11-18  7:20   ` [EXT] " Akhil Goyal
  0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Mingshan @ 2021-11-17  1:55 UTC (permalink / raw)
  To: dev, akhil.goyal; +Cc: nicolas.chautru, Mingshan Zhang

From: Mingshan Zhang <mingshan.zhang@intel.com>

update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
 
Signed-off-by: Mingshan Zhang <mingshan.zhang@intel.com>
---
 doc/guides/prog_guide/bbdev.rst | 4 ++--
 lib/bbdev/rte_bbdev_op.h        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index 70fa01a..c330e08 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -387,10 +387,10 @@ allocate bbdev operations of a specific type from a given bbdev operation mempoo
 .. code-block:: c
 
     int rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
-            struct rte_bbdev_enc_op **ops, uint16_t num_ops)
+            struct rte_bbdev_enc_op **ops, uint32_t num_ops)
 
     int rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
-            struct rte_bbdev_dec_op **ops, uint16_t num_ops)
+            struct rte_bbdev_dec_op **ops, uint32_t num_ops)
 
 ``rte_bbdev_*_op_free_bulk()`` is called by the application to return an
 operation to its allocating pool.
diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index 5512859..f074b35 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -867,7 +867,7 @@ struct rte_mempool *
 __rte_experimental
 static inline int
 rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
-		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
+		struct rte_bbdev_enc_op **ops, uint32_t num_ops)
 {
 	struct rte_bbdev_op_pool_private *priv;
 	int ret;
@@ -904,7 +904,7 @@ struct rte_mempool *
 __rte_experimental
 static inline int
 rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
-		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
+		struct rte_bbdev_dec_op **ops, uint32_t num_ops)
 {
 	struct rte_bbdev_op_pool_private *priv;
 	int ret;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [EXT] [PATCH -v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
  2021-11-17  1:55 ` [PATCH -v1] bbdev: update " Zhang, Mingshan
@ 2021-11-18  7:20   ` Akhil Goyal
  2021-11-18 15:16     ` Chautru, Nicolas
  0 siblings, 1 reply; 5+ messages in thread
From: Akhil Goyal @ 2021-11-18  7:20 UTC (permalink / raw)
  To: Zhang, Mingshan, dev, akhil.goyal; +Cc: nicolas.chautru

> From: Mingshan Zhang <mingshan.zhang@intel.com>

Title is too big. Please run ./devtools/check-git-log.sh.
> 
> update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
Explain the need for this change. We only take critical fixes in the APIs for RC4.
Bbdev APIs are not experimental anymore. Please rebase on TOT.
This change is an API change which may need deprecation notice from next release.

> 
> Signed-off-by: Mingshan Zhang <mingshan.zhang@intel.com>
> ---
>  doc/guides/prog_guide/bbdev.rst | 4 ++--
>  lib/bbdev/rte_bbdev_op.h        | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/guides/prog_guide/bbdev.rst
> b/doc/guides/prog_guide/bbdev.rst
> index 70fa01a..c330e08 100644
> --- a/doc/guides/prog_guide/bbdev.rst
> +++ b/doc/guides/prog_guide/bbdev.rst
> @@ -387,10 +387,10 @@ allocate bbdev operations of a specific type from a
> given bbdev operation mempoo
>  .. code-block:: c
> 
>      int rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> -            struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> +            struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> 
>      int rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> -            struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> +            struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> 
>  ``rte_bbdev_*_op_free_bulk()`` is called by the application to return an
>  operation to its allocating pool.
> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
> index 5512859..f074b35 100644
> --- a/lib/bbdev/rte_bbdev_op.h
> +++ b/lib/bbdev/rte_bbdev_op.h
> @@ -867,7 +867,7 @@ struct rte_mempool *
>  __rte_experimental
>  static inline int
>  rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_enc_op **ops, uint32_t num_ops)
>  {
>  	struct rte_bbdev_op_pool_private *priv;
>  	int ret;
> @@ -904,7 +904,7 @@ struct rte_mempool *
>  __rte_experimental
>  static inline int
>  rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_dec_op **ops, uint32_t num_ops)
>  {
>  	struct rte_bbdev_op_pool_private *priv;
>  	int ret;
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [EXT] [PATCH -v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
  2021-11-18  7:20   ` [EXT] " Akhil Goyal
@ 2021-11-18 15:16     ` Chautru, Nicolas
  0 siblings, 0 replies; 5+ messages in thread
From: Chautru, Nicolas @ 2021-11-18 15:16 UTC (permalink / raw)
  To: Akhil Goyal, Zhang, Mingshan, dev, akhil.goyal

Hi Akhil, 
The change below from Mingshan is not for 21.11, this is targeting following release. It should have been mentioned in cover letter. 
Thanks
Nic


> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Wednesday, November 17, 2021 11:21 PM
> To: Zhang, Mingshan <mingshan.zhang@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>
> Subject: RE: [EXT] [PATCH -v1] bbdev: update num_ops type to be uint32_t in
> rte_bbdev_enc_op_alloc_bulk
> 
> > From: Mingshan Zhang <mingshan.zhang@intel.com>
> 
> Title is too big. Please run ./devtools/check-git-log.sh.
> >
> > update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
> Explain the need for this change. We only take critical fixes in the APIs for
> RC4.
> Bbdev APIs are not experimental anymore. Please rebase on TOT.
> This change is an API change which may need deprecation notice from next
> release.
> 
> >
> > Signed-off-by: Mingshan Zhang <mingshan.zhang@intel.com>
> > ---
> >  doc/guides/prog_guide/bbdev.rst | 4 ++--
> >  lib/bbdev/rte_bbdev_op.h        | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/bbdev.rst
> > b/doc/guides/prog_guide/bbdev.rst index 70fa01a..c330e08 100644
> > --- a/doc/guides/prog_guide/bbdev.rst
> > +++ b/doc/guides/prog_guide/bbdev.rst
> > @@ -387,10 +387,10 @@ allocate bbdev operations of a specific type
> > from a given bbdev operation mempoo  .. code-block:: c
> >
> >      int rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> > -            struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> > +            struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> >
> >      int rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> > -            struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> > +            struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> >
> >  ``rte_bbdev_*_op_free_bulk()`` is called by the application to return
> > an  operation to its allocating pool.
> > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index
> > 5512859..f074b35 100644
> > --- a/lib/bbdev/rte_bbdev_op.h
> > +++ b/lib/bbdev/rte_bbdev_op.h
> > @@ -867,7 +867,7 @@ struct rte_mempool *  __rte_experimental  static
> > inline int  rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> >  {
> >  	struct rte_bbdev_op_pool_private *priv;
> >  	int ret;
> > @@ -904,7 +904,7 @@ struct rte_mempool *  __rte_experimental  static
> > inline int  rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> >  {
> >  	struct rte_bbdev_op_pool_private *priv;
> >  	int ret;
> > --
> > 1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH -v1] Update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
@ 2021-11-16  5:12 Zhang, Mingshan
  0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Mingshan @ 2021-11-16  5:12 UTC (permalink / raw)
  To: dev, akhil.goyal; +Cc: nicolas.chautru, Zhang, Mingshan

From: "Zhang, Mingshan" <mingshan.zhang@intel.com>

Update num_ops type from uint16_t to uint32_t in rte_bbdev_enc_op_alloc_bulk to enlarge the input range.

Nicolas Chautru (1):
  SCSY-51090 ACC100 Padding 5GDL input BLEN

 drivers/baseband/acc100/rte_acc100_pmd.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-18 15:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17  1:55 [PATCH -v1] Update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk Zhang, Mingshan
2021-11-17  1:55 ` [PATCH -v1] bbdev: update " Zhang, Mingshan
2021-11-18  7:20   ` [EXT] " Akhil Goyal
2021-11-18 15:16     ` Chautru, Nicolas
  -- strict thread matches above, loose matches on Subject: below --
2021-11-16  5:12 [PATCH -v1] Update " Zhang, Mingshan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).