From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id DD71BADEB for ; Fri, 20 May 2016 14:03:22 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id n129so79624815wmn.1 for ; Fri, 20 May 2016 05:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=zxeHkC/orCfy/uS76ituW4ef49e0mVhhO7b+PmFE4Q4=; b=uhPTy3BFE1tLGh8e1ew461+3EtHcTzQPoENbibsy4E967Si61E/6x7xWIOBxffekV7 AcOV4+MqhYawJEI1IBvFyZY2rWLKhDz1Hh76oANRyXUem+nqVxUbyzIyV41hhBezDDa2 2JofyPZqt2nabXuQh1rJa4phFKRoSbhbW8XCoWvjdrBZ/Unek+qdK0itL9nYo0uTSTfS c2znFc/q+o8p+0ojANXvFlOhv3YkZqGLr6fREpqFEnZT3qY7vqbIHsyucvPgdtaBpP1m ma2eMmaVJctASC1RmYnvToGltPElxrfmByQZ0Yj68qCojpL8n6j4Iiook4lizWJ184O2 U9Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=zxeHkC/orCfy/uS76ituW4ef49e0mVhhO7b+PmFE4Q4=; b=OrGZWFPPY736PloSTTS+FG5VdkctLbZANqlwEfXy183rSIzQka9r7nPbCvlgauWO74 NhsbLjlE1Rd7WyVx8eD/jx5xfK/3cfNuZueN7CAyJgDBFC/dIuNw7TcdntM9qy02VNgU zaBhUCESUCw8dYZ/uokluO4Sycj7QpKepCFMNlVllzMKD+N+xyp1x6NXPeE3EnWX9Eji ALxJizA+nagzPSsjVendVV/XnxCKA+cqCePChX3jaRgK63xHZAJwkOL/UN+K4qpeymXR jrsXmuAAIo2mzy3GNMvOUie1SE5BGGbMk1KjeddiKOPdOp3c42CbCerzSvVF8be0PPMl yM+g== X-Gm-Message-State: AOPr4FVSlDMxeU1wCI6cRQPEWBp9WvH/yM/orKZt4KQ230NYzM6fUnofVU6/86cp8ZepPfkV X-Received: by 10.194.110.137 with SMTP id ia9mr2925166wjb.107.1463745802558; Fri, 20 May 2016 05:03:22 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id xz3sm19493409wjb.10.2016.05.20.05.03.21 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 May 2016 05:03:21 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org, Tetsuya Mukawa , Yuanhan Liu Date: Fri, 20 May 2016 14:03:20 +0200 Message-ID: <1638192.xyCv6GChDS@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160520103746.GA19260@bricha3-MOBL3> References: <20160509213124.GK5641@yliu-dev.sh.intel.com> <1891939.OmQDtN0y3O@xps13> <20160520103746.GA19260@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] vhost: add support for dynamic vhost PMD creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 12:03:23 -0000 2016-05-20 11:37, Bruce Richardson: > On Thu, May 19, 2016 at 06:44:44PM +0200, Thomas Monjalon wrote: > > 2016-05-19 17:28, Ferruh Yigit: > > > On 5/19/2016 9:33 AM, Thomas Monjalon wrote: > > > > 2016-05-18 18:10, Ferruh Yigit: > > > >> Add rte_eth_from_vhost() API to create vhost PMD dynamically from > > > >> applications. > > > > > > > > How is it different from rte_eth_dev_attach() calling rte_eal_vdev_init()? > > > > > > > > > > When used rte_eth_dev_attach(), application also needs to do: > > > rte_eth_dev_configure() > > > rte_eth_rx_queue_setup() > > > rte_eth_tx_queue_setup() > > > rte_eth_dev_start() > > > > > > rte_eth_from_vhost() does these internally, easier to use for applications. > > > > This argument is not sufficient. > > We are not going to add new APIs just for wrapping others. > > Why not - if there is a sufficient increase in developer usability by doing so? > Having one API that saves an app from having to call 5 other APIs looks like > something that should always be given fair consideration. There will obviously > be other factors to take into account too, like numbers and types of parameters > to the replacement call vs the sub-calls, but I don't think a blanket ban is > justified. Yes, everything can be discussed, especially the ethdev API which is far from being perfect :)