From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 347D7BD5B for ; Wed, 26 Oct 2016 18:54:09 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id 140so27621591wmv.0 for ; Wed, 26 Oct 2016 09:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=3aHlfbe0BOFDUmSnzDp+DZe9TolFQuU8UpilOToB3jQ=; b=ZGpsxdOkTJo941KQAwkHAMbLP0faPQTyFfwQo24bZ/qQk4/48fp1GaB+9zWft4hhOk teF5iyh899fx83PH3+1+zm0ivXdHOE9rrb/ZLhNMfEQoamyXJBe0SWUh5NCsbyCxASaR dESQmHZtVlKIsZuBC6J+o1nyuIxdl8KQD3kScLBN6SxD8O2RX04UVKiVJf7IanFlSvky FJnuDlgfimdaL14CbWFfdDr24ZvKLQ55GXtge8ABOVFYPzXgphszuIvU4Mx1hfoNc/PI RDB2VSxH6U9x8qT62XKWuglSv39Vg86ALB1M9M6ZBqR/j48jShCt4kGvE1uQBDav+l9s YZFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=3aHlfbe0BOFDUmSnzDp+DZe9TolFQuU8UpilOToB3jQ=; b=UMwpB5acjrLqJIrfM50oj8cwOcs+Rs8lVnDI0H0qoVZ5r+oBHmaQhfp5gQedJpzw0p KRWtYesdV+4q8ZodyHVBL9KHcLq3XeQsD31e9qP3h//eTzagYfXeitM2EZN2HtFWXfiD RYep+nH0+PK5l52ucmSkJF7pcG7cR+b5HLHD9Ck9WddMHCwEeYOc9xBbgvPV/m7eHV88 woIEgSfl+ZqJWDbOuCPbmGU4SXGrgWo2pU3+RKJK4Fm2+ESIkAUyZ86v5d/0bwMoCp0l amJ6QmqtWRgaJHA4A/eJqkWcx0vYqXa7MowXElG3swKvABRHJHQguxr+rrH+2hhSgs45 fGzQ== X-Gm-Message-State: ABUngvfUZ13wd08e5xt6oaypT4vAcnXBVupbl3jzr8tPSAIQYIvg0HMDOPKNc+TZIIG1STLQ X-Received: by 10.28.15.17 with SMTP id 17mr9912293wmp.55.1477500846803; Wed, 26 Oct 2016 09:54:06 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w65sm4047836wmd.23.2016.10.26.09.54.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Oct 2016 09:54:05 -0700 (PDT) From: Thomas Monjalon To: Rasesh Mody Date: Wed, 26 Oct 2016 18:54:04 +0200 Message-ID: <1638805.EFUnSErrGQ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1476850306-2141-8-git-send-email-rasesh.mody@qlogic.com> References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com> <1476850306-2141-8-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com, ferruh.yigit@intel.com Subject: Re: [dpdk-dev] [PATCH v4 07/32] net/qede: fix 32 bit compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 16:54:09 -0000 2016-10-18 21:11, Rasesh Mody: > Fix 32 bit compilation for gcc version 4.3.4. > > Fixes: ec94dbc57362 ("qede: add base driver") > > Signed-off-by: Rasesh Mody [...] > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > +ifeq ($(shell gcc -Wno-unused-but-set-variable -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0) > CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > +endif > CFLAGS_BASE_DRIVER += -Wno-missing-declarations > +ifeq ($(shell gcc -Wno-maybe-uninitialized -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0) > CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized > +endif > CFLAGS_BASE_DRIVER += -Wno-strict-prototypes > ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > CFLAGS_BASE_DRIVER += -Wno-shift-negative-value What the hell are you doing here? 1/ You should better fix "unused-but-set-variable" errors 2/ It won't work when cross-compiling because you do not use $(CC) in $(shell gcc I really do not want to look at the qede patches. But each time my eyes stop on one of them, I'm struggling.