DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: thomas@monjalon.net, david.marchand@redhat.com,
	Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com,
	ferruh.yigit@intel.com, jerinjacobk@gmail.com
Cc: dev@dpdk.org, "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Subject: [PATCH v2 1/4] doc: arm64 cross build CFLAGS/LDFLAGS alternatives
Date: Tue,  7 Dec 2021 12:05:06 +0100	[thread overview]
Message-ID: <1638875109-5544-2-git-send-email-juraj.linkes@pantheon.tech> (raw)
In-Reply-To: <1638875109-5544-1-git-send-email-juraj.linkes@pantheon.tech>

Remove CFLAGS and LDFLAGS since Meson doesn't support them well enough.
Add Meson alternatives: -Dc_args and -Dc_link_args on the command line
and in cross files.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 .../linux_gsg/cross_build_dpdk_for_arm64.rst  | 25 ++++++++++++++++---
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index d59af58235..51075bd4a9 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -98,10 +98,6 @@ For aarch32::
 Augment the GNU toolchain with NUMA support
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-.. note::
-
-   This way is optional, an alternative is to use extra CFLAGS and LDFLAGS.
-
 Copy the NUMA header files and lib to the cross compiler's directories:
 
 .. code-block:: console
@@ -110,6 +106,27 @@ Copy the NUMA header files and lib to the cross compiler's directories:
    cp <numa_install_dir>/lib/libnuma.a <cross_install_dir>/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu/lib/gcc/aarch64-none-linux-gnu/9.2.1/
    cp <numa_install_dir>/lib/libnuma.so <cross_install_dir>/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu/lib/gcc/aarch64-none-linux-gnu/9.2.1/
 
+.. note::
+
+   Using LDFLAGS and CFLAGS is not a viable alternative to copying the files.
+   The Meson docs say it is not recommended, as there are many caveats to their
+   use with Meson, especially when rebuilding the project. A viable alternative
+   would be to use the ``c_args`` and ``c_link_args`` options with Meson 0.51.0
+   and higher:
+
+.. code-block:: console
+
+   -Dc_args=-I<numa_install_dir>/include -Dc_link_args=-L<numa_install_dir>/lib
+
+   For Meson versions lower than 0.51.0, the ``c_args`` and ``c_link_args``
+   options don't apply to cross compilation. However, the compiler/linker flags
+   may be added to cross files under [properties]:
+
+.. code-block:: console
+
+   c_args = ['-I<numa_install_dir>/include']
+   c_link_args = ['-L<numa_install_dir>/lib']
+
 Cross Compiling DPDK with GNU toolchain using Meson
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-- 
2.20.1


  reply	other threads:[~2021-12-07 11:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 10:00 [PATCH v1] doc: arm64 cross docs improvements/fixes Juraj Linkeš
2021-11-26 13:53 ` Thomas Monjalon
2021-11-26 14:17   ` Juraj Linkeš
2021-12-07 11:05 ` [PATCH v2 0/4] " Juraj Linkeš
2021-12-07 11:05   ` Juraj Linkeš [this message]
2021-12-15  8:00     ` [PATCH v2 1/4] doc: arm64 cross build CFLAGS/LDFLAGS alternatives Ruifeng Wang
2021-12-07 11:05   ` [PATCH v2 2/4] doc: arm64 cross build binary names update Juraj Linkeš
2021-12-15  8:02     ` Ruifeng Wang
2021-12-07 11:05   ` [PATCH v2 3/4] doc: arm64 cross build numactl compilers Juraj Linkeš
2021-12-15  8:38     ` Ruifeng Wang
2021-12-07 11:05   ` [PATCH v2 4/4] docs: add an example arm64 cross file Juraj Linkeš
2021-12-15  8:59     ` Ruifeng Wang
2022-01-25 13:19   ` [PATCH v3 0/4] arm64 cross docs improvements/fixes Juraj Linkeš
2022-01-25 13:19     ` [PATCH v3 1/4] doc: arm64 cross build CFLAGS/LDFLAGS alternatives Juraj Linkeš
2022-01-25 13:20     ` [PATCH v3 2/4] doc: arm64 cross build binary names update Juraj Linkeš
2022-01-25 13:20     ` [PATCH v3 3/4] doc: arm64 cross build numactl compilers Juraj Linkeš
2022-01-25 13:20     ` [PATCH v3 4/4] doc: add an example arm64 cross file Juraj Linkeš
2022-03-16 19:19     ` [PATCH v3 0/4] arm64 cross docs improvements/fixes Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1638875109-5544-2-git-send-email-juraj.linkes@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).