From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5A729A00BE;
	Tue,  7 Jul 2020 09:15:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E424C1DADA;
	Tue,  7 Jul 2020 09:15:44 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1676E1DA2B
 for <dev@dpdk.org>; Tue,  7 Jul 2020 09:15:43 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id B87255C010F;
 Tue,  7 Jul 2020 03:15:40 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Tue, 07 Jul 2020 03:15:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 CuuTaAHPKfnX6e5nSrss0mykRXTbN5Aro/FWIPrICxk=; b=uADLTdqnEfGhiGiU
 Ou9wDDbgiHlWwrxNgBjJfoGmpkAZrVvzSI+e554w1kVNrjr7WHS6na+qQHp7D36O
 F8AtNiSuzW4M16whCyYZ456YAN0hgwELVqgGRFjs6RmHGVQoRzerihB9gVw02L5P
 SpL3zGmHec7AwxNo7LsAn0EgTIQaEf0UeuXxL/MdvggYdiByVjraGmS05aSwTV+u
 eAtbuyGtTMIBVmHfAzxPfrHrE6Xf+HPaXKwJqaBmNAGiTM71YnOG2Yz3S0qvvV2k
 Hefw/udN2NGFyMq8QIDxgVsv/mTr0pibRn7hjpsPPvvl2C/ntzrsDPFFHzkDzFei
 i0V31g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; bh=CuuTaAHPKfnX6e5nSrss0mykRXTbN5Aro/FWIPrIC
 xk=; b=mwFbYWCruJ3n/FDQxmcGn4Mqvu4HnFLo7THbS6kKH758d6ILnBzUq8plX
 homXSCNfDfi26xZlNjTcl/g0pZ5RM/npjK6Xiqtz7don1sm8b0AvmqurAVvL+k+y
 do/GmFvPKe+D1IXTtnd/9uMc96Q+89SGxi17wWJN8MOeToRsAp3Ly7k+Q8AOQsar
 HH7FIYELl30zlZw0ccSxTh+RMzNL9uvwP5T6n4f1CISEN4oHrGbRNv90u6bpoDwz
 P/WgeHxigVOU/A790OTVDSdSNekimgqgixh+xYU7b+a5jPbZYL1d+Z/nqohT+k8E
 NHmCzPXobaHhBvpfjzD5BsSQtkLSA==
X-ME-Sender: <xms:HCEEX4iD1Y41fD4V369z-q1YSXcItCoLEHF80FqZv0YR6suJZa3zaA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeggdduvdduucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:HCEEXxBNax7njH2hbY6u-hr3A030Xv0K1ULjos3Jr8WYH-6XoQBnOw>
 <xmx:HCEEXwGIDD24gMurcU5NDVOcYbnfS8IgiVEaKGk7wjh5_ZcqNYXtyw>
 <xmx:HCEEX5Q6VsRJ0_viwWt95ZDP8TsTzP42q0eq3Ps67d0ABbdwd7CKww>
 <xmx:HCEEXw-KRJc-T3wLsozszPAlO3bMJembqFAHbDo0wk9vUuSBdoH8JQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8A2FC3060067;
 Tue,  7 Jul 2020 03:15:39 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ciara Power <ciara.power@intel.com>
Cc: kevin.laatz@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com,
 dev@dpdk.org, keith.wiles@intel.com
Date: Tue, 07 Jul 2020 09:15:37 +0200
Message-ID: <1638968.XUGDyZqEU4@thomas>
In-Reply-To: <20200702101953.6129-2-ciara.power@intel.com>
References: <20200612105344.15383-1-ciara.power@intel.com>
 <20200702101953.6129-1-ciara.power@intel.com>
 <20200702101953.6129-2-ciara.power@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 1/2] telemetry: support array values in
	data objects
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/07/2020 12:19, Ciara Power:
> +/**
> + * Add a container to a dictionary. A container is an existing telemetry data
> + * array. The dict the container is to be added to must have been started by
> + * rte_tel_data_start_dict(). The container must be an array of type
> + * uint64_t/int/string.
> + *
> + * @param d
> + *   The data structure passed to the callback
> + * @param val
> + *   The pointer to the container to be stored in the dict.
> + * @param keep
> + *   Flag to indicate that the container memory should not be automatically
> + *   freed by the telemetry library once it has finished with the data.
> + *   1 = keep, 0 = free.
> + * @return
> + *   0 on success, negative errno on error
> + */
> +__rte_experimental
> +int
> +rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name,
> +		struct rte_tel_data *val, int keep);

Please fix this miss:

rte_telemetry.h:233: warning: The following parameter of rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name, struct rte_tel_data *val, int keep) is not documented:
+  parameter 'name'