DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file
@ 2020-07-07 12:25 levendsayar
  2020-07-07 14:19 ` Thomas Monjalon
  2020-07-09 12:32 ` [dpdk-dev] [PATCH v3] service: support C++ linkage levendsayar
  0 siblings, 2 replies; 8+ messages in thread
From: levendsayar @ 2020-07-07 12:25 UTC (permalink / raw)
  To: thomas; +Cc: dev, Levend Sayar

From: Levend Sayar <levendsayar@gmail.com>

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
 lib/librte_eal/include/rte_service_component.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h
index b75aba11b..c1eefae41 100644
--- a/lib/librte_eal/include/rte_service_component.h
+++ b/lib/librte_eal/include/rte_service_component.h
@@ -9,6 +9,11 @@
  * Include this file if you are writing a component that requires CPU cycles to
  * operate, and you wish to run the component using service cores
  */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <rte_compat.h>
 #include <rte_service.h>
 
@@ -130,4 +135,8 @@ int32_t rte_service_init(void);
  */
 void rte_service_finalize(void);
 
-#endif /* _SERVICE_PRIVATE_H_ */
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* _RTE_SERVICE_PRIVATE_H_ */
-- 
2.27.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file
  2020-07-07 12:25 [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file levendsayar
@ 2020-07-07 14:19 ` Thomas Monjalon
  2020-07-07 15:00   ` Van Haaren, Harry
  2020-07-09 12:32 ` [dpdk-dev] [PATCH v3] service: support C++ linkage levendsayar
  1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2020-07-07 14:19 UTC (permalink / raw)
  To: levendsayar; +Cc: dev, harry.van.haaren, david.marchand

07/07/2020 14:25, levendsayar@gmail.com:
> From: Levend Sayar <levendsayar@gmail.com>

Would be good to have a short explanation, even if obvious.

> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
>  lib/librte_eal/include/rte_service_component.h | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Is it the only file missing such C++ guard?



> --- a/lib/librte_eal/include/rte_service_component.h
> +++ b/lib/librte_eal/include/rte_service_component.h
> @@ -9,6 +9,11 @@
>   * Include this file if you are writing a component that requires CPU cycles to
>   * operate, and you wish to run the component using service cores
>   */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #include <rte_compat.h>
>  #include <rte_service.h>
>  
> @@ -130,4 +135,8 @@ int32_t rte_service_init(void);
>   */
>  void rte_service_finalize(void);
>  
> -#endif /* _SERVICE_PRIVATE_H_ */
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_SERVICE_PRIVATE_H_ */
> 






^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file
  2020-07-07 14:19 ` Thomas Monjalon
@ 2020-07-07 15:00   ` Van Haaren, Harry
  2020-07-07 15:31     ` Levend Sayar
  0 siblings, 1 reply; 8+ messages in thread
From: Van Haaren, Harry @ 2020-07-07 15:00 UTC (permalink / raw)
  To: Thomas Monjalon, levendsayar; +Cc: dev, david.marchand

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, July 7, 2020 3:19 PM
> To: levendsayar@gmail.com
> Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> david.marchand@redhat.com
> Subject: Re: [PATCH] build: C++ linkage support is added to
> rte_service_component.h file
> 
> 07/07/2020 14:25, levendsayar@gmail.com:
> > From: Levend Sayar <levendsayar@gmail.com>
> 
> Would be good to have a short explanation, even if obvious.

+1

> > Signed-off-by: Levend Sayar <levendsayar@gmail.com>

With a short description in the commit message, you can include ack in v2
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

<snip patch>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file
  2020-07-07 15:00   ` Van Haaren, Harry
@ 2020-07-07 15:31     ` Levend Sayar
  0 siblings, 0 replies; 8+ messages in thread
From: Levend Sayar @ 2020-07-07 15:31 UTC (permalink / raw)
  To: Van Haaren, Harry; +Cc: Thomas Monjalon, dev, david.marchand

Sorry.
I thought that it does not need to have any explanation since it is obvious
as you said.
But will add an explanation right now and push again.

Thanks for your attention.

Best,
Levend

On Tue, Jul 7, 2020 at 6:01 PM Van Haaren, Harry <harry.van.haaren@intel.com>
wrote:

> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, July 7, 2020 3:19 PM
> > To: levendsayar@gmail.com
> > Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> > david.marchand@redhat.com
> > Subject: Re: [PATCH] build: C++ linkage support is added to
> > rte_service_component.h file
> >
> > 07/07/2020 14:25, levendsayar@gmail.com:
> > > From: Levend Sayar <levendsayar@gmail.com>
> >
> > Would be good to have a short explanation, even if obvious.
>
> +1
>
> > > Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>
> With a short description in the commit message, you can include ack in v2
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> <snip patch>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v3] service: support C++ linkage
  2020-07-07 12:25 [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file levendsayar
  2020-07-07 14:19 ` Thomas Monjalon
@ 2020-07-09 12:32 ` levendsayar
  2020-07-09 13:21   ` Thomas Monjalon
  1 sibling, 1 reply; 8+ messages in thread
From: levendsayar @ 2020-07-09 12:32 UTC (permalink / raw)
  To: thomas; +Cc: dev, Levend Sayar, Harry van Haaren

From: Levend Sayar <levendsayar@gmail.com>

"extern C" define is added to rte_service_component.h file
to be able to use in C++ context

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
 lib/librte_eal/include/rte_service_component.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h
index b75aba11b..9e66ee7e2 100644
--- a/lib/librte_eal/include/rte_service_component.h
+++ b/lib/librte_eal/include/rte_service_component.h
@@ -9,6 +9,11 @@
  * Include this file if you are writing a component that requires CPU cycles to
  * operate, and you wish to run the component using service cores
  */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <rte_compat.h>
 #include <rte_service.h>
 
@@ -130,4 +135,8 @@ int32_t rte_service_init(void);
  */
 void rte_service_finalize(void);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _SERVICE_PRIVATE_H_ */
-- 
2.27.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v3] service: support C++ linkage
  2020-07-09 12:32 ` [dpdk-dev] [PATCH v3] service: support C++ linkage levendsayar
@ 2020-07-09 13:21   ` Thomas Monjalon
  2020-07-09 13:56     ` Levend Sayar
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2020-07-09 13:21 UTC (permalink / raw)
  To: Levend Sayar; +Cc: dev, Harry van Haaren

09/07/2020 14:32, levendsayar@gmail.com:
> From: Levend Sayar <levendsayar@gmail.com>
> 
> "extern C" define is added to rte_service_component.h file
> to be able to use in C++ context

It is a bug.
The title should be "service: fix C++ linkage"
And these tags must be added:
Fixes: 21698354c832 ("service: introduce service cores concept")
Cc: stable@dpdk.org

If you agree, I can do the change while merging.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v3] service: support C++ linkage
  2020-07-09 13:21   ` Thomas Monjalon
@ 2020-07-09 13:56     ` Levend Sayar
  2020-07-09 14:24       ` Thomas Monjalon
  0 siblings, 1 reply; 8+ messages in thread
From: Levend Sayar @ 2020-07-09 13:56 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Harry van Haaren

Sure I agree Thomas.

Thanks in advance.

Best,
Levend

On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> 09/07/2020 14:32, levendsayar@gmail.com:
> > From: Levend Sayar <levendsayar@gmail.com>
> >
> > "extern C" define is added to rte_service_component.h file
> > to be able to use in C++ context
>
> It is a bug.
> The title should be "service: fix C++ linkage"
> And these tags must be added:
> Fixes: 21698354c832 ("service: introduce service cores concept")
> Cc: stable@dpdk.org
>
> If you agree, I can do the change while merging.
>
>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v3] service: support C++ linkage
  2020-07-09 13:56     ` Levend Sayar
@ 2020-07-09 14:24       ` Thomas Monjalon
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2020-07-09 14:24 UTC (permalink / raw)
  To: Levend Sayar; +Cc: dev, Harry van Haaren, stable

09/07/2020 15:56, Levend Sayar:
> On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 09/07/2020 14:32, levendsayar@gmail.com:
> > > From: Levend Sayar <levendsayar@gmail.com>
> > >
> > > "extern C" define is added to rte_service_component.h file
> > > to be able to use in C++ context
> >
> > It is a bug.
> > The title should be "service: fix C++ linkage"
> > And these tags must be added:
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Cc: stable@dpdk.org
> >
> > If you agree, I can do the change while merging.
> 
> Sure I agree Thomas.
> 
> Thanks in advance.

Applied, thanks



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-07-09 14:24 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 12:25 [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file levendsayar
2020-07-07 14:19 ` Thomas Monjalon
2020-07-07 15:00   ` Van Haaren, Harry
2020-07-07 15:31     ` Levend Sayar
2020-07-09 12:32 ` [dpdk-dev] [PATCH v3] service: support C++ linkage levendsayar
2020-07-09 13:21   ` Thomas Monjalon
2020-07-09 13:56     ` Levend Sayar
2020-07-09 14:24       ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).