From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FDDAA04BA; Wed, 7 Oct 2020 12:06:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 41A734C9D; Wed, 7 Oct 2020 12:06:19 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7D27FA3 for <dev@dpdk.org>; Wed, 7 Oct 2020 12:06:17 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 244EB5C018B; Wed, 7 Oct 2020 06:06:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 07 Oct 2020 06:06:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= xG5q/0ssdEqMQVK+/oIgysm+PUkolMG7EtQaRr4CGeA=; b=M28jHhKu4eKjM0nz msa+JMlCFJ+p3KZJTEjDYX7K4R5SN/65s8RnLUFMBeIChP0kOa+PmZGD//Br8zbf 0dSiyGcS5JZMyyQu/HZPaLUL/Gur5CTWFge0d9JPYJTyZF0Qup322DX8ib+yqN0V P+0GrYBJuZVN7c3tZkf1WE0XzF1PlJdbZeVD6SFPHRYLpN/FsNjRfv7uvkuZiaEy CWUe0SjM1IIhKcTuzz8JeTqQvVhUyUcOjH4GvpmiAP5ExoiVCgwmqx58DliUh5nN 8YwbGIBhvHf1CZ82kt/Wqf7IRC4OhCzksBSUZlsJRv8ueHGmmQNTxQNFUCQ0qf26 xxDCLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=xG5q/0ssdEqMQVK+/oIgysm+PUkolMG7EtQaRr4CG eA=; b=n0j0scM+jOw7OGwz48jg27veQ2dVBMXZiePaxEX74GYqFP4lDe5WZ+tKM IgFHxY8rK3Y+5Yval7EG8ujhm+PYS+Kap2D2oaxD6+F9PMxrvzK01MFOH4IjNBiQ 53LoCBLpOX3UVtUd9QJdsdfIl5VggXE6S26k5E9b5q0VlOjZmcoFsQgp4YqZM730 T1Kf9qWbnoFL8Y2opLTM8swmOFouODvUq09jrSjuKQ9sm6dFGTI6v+gaTacYGfrO k7LH9lO8zzH5JxqOItLBStc4o7fx3KYGPUh5KiVETIAGOsOmODkYaogcaj4rB4+u F7kvVmQh7ZQlinEX1ViV3WmyBB1cw== X-ME-Sender: <xms:FpN9X7LGB9GBVMBaIBgt6DrCle3zqCYkt1tMwIjnDPMLhTHOLy-KGw> <xme:FpN9X_Kh4cyKK-gcy6XIwXCGGMGXP6cg6mv9w-Bi2joEZT7k4CSqptNtGqNwHM5dG db7HzXbJH0N2j4ztg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeigddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:F5N9Xzu4CRLM03oMrQ39m25Xxa7DErtK9jFdKMGPKWsgwU5am1CBfg> <xmx:F5N9X0bf764ELbZSWJljHhpqfx5OlplXT1MBP1RM1ZpUr_vj-kT1Bg> <xmx:F5N9Xya5hsOfqlgg1jLCEtYLcDfGZ9y38mNNzhYj36YjA8dbhUYSdQ> <xmx:GJN9X5wNOoLqzb5-sNywCEP7OMS5z2uqtiu-dXeXTG9V_Qfoffm-VA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 244D2306467D; Wed, 7 Oct 2020 06:06:14 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: David Marchand <david.marchand@redhat.com> Cc: dev <dev@dpdk.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Bruce Richardson <bruce.richardson@intel.com>, "Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>, Jan Viktorin <viktorin@rehivetech.com>, David Christensen <drc@linux.vnet.ibm.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Date: Wed, 07 Oct 2020 12:06:13 +0200 Message-ID: <1639188.Are77gBJog@thomas> In-Reply-To: <CAJFAV8ygwgswdBRd=n2Een5ucz9=QyEZZ-waPo47+SSobZ8ucg@mail.gmail.com> References: <20201006202250.3623749-1-thomas@monjalon.net> <CAJFAV8ygwgswdBRd=n2Een5ucz9=QyEZZ-waPo47+SSobZ8ucg@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] maintainers: improve coverage of arch-specific files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 07/10/2020 09:44, David Marchand: > On Tue, Oct 6, 2020 at 10:23 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > The sub-directories of config/ are maintained by > > different architecture maintainers. > > > > Some wildcards are used to describe the lib and drivers files > > which are specific to some architectures. > > I noticed "some" misses, see below. > > > > > The EAL Arm files have split responsibilities depending on 32/64 suffix, > > and the common files are shared between Armv7 and Armv8 sections. > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > > MAINTAINERS | 23 +++++++++++------------ > > 1 file changed, 11 insertions(+), 12 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 75a17d51c0..349fc9c38a 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -256,32 +256,31 @@ F: app/test/test_rand_perf.c > > ARM v7 > > M: Jan Viktorin <viktorin@rehivetech.com> > > M: Ruifeng Wang <ruifeng.wang@arm.com> > > +F: config/arm/ > > F: lib/librte_eal/arm/ > > +X: lib/librte_eal/arm/include/*_64.h > > > > ARM v8 > > M: Jerin Jacob <jerinj@marvell.com> > > M: Ruifeng Wang <ruifeng.wang@arm.com> > > -F: lib/librte_eal/arm/include/*_64.h > > -F: lib/librte_net/net_crc_neon.h > > -F: lib/librte_acl/acl_run_neon.* > > -F: lib/librte_bpf/bpf_jit_arm64.c > > -F: lib/librte_lpm/rte_lpm_neon.h > > -F: lib/librte_hash/rte*_arm64.h > > -F: lib/librte_efd/rte*_arm64.h > > -F: lib/librte_table/rte*_arm64.h > > -F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c > > -F: drivers/net/i40e/i40e_rxtx_vec_neon.c > > -F: drivers/net/virtio/virtio_rxtx_simple_neon.c > > +F: config/arm/ > > +F: lib/librte_eal/arm/ > > +X: lib/librte_eal/arm/include/*_32.h > > +F: lib/*/*_neon.* > > +F: lib/*/*_arm64.* > > +F: drivers/*/*/*_neon.* > > app and examples directory are not caught in this: > > ./lib/librte_net/net_crc_neon.h > ./lib/librte_acl/acl_run_neon.h > ./lib/librte_acl/acl_run_neon.c > ./lib/librte_lpm/rte_lpm_neon.h > ./lib/librte_node/ip4_lookup_neon.h > ./examples/l3fwd/l3fwd_lpm_neon.h > ./examples/l3fwd/l3fwd_em_hlm_neon.h > ./examples/l3fwd/l3fwd_neon.h > ./app/test-pmd/macswap_neon.h > ./drivers/net/hns3/hns3_rxtx_vec_neon.h > ./drivers/net/bnxt/bnxt_rxtx_vec_neon.c > ./drivers/net/mlx5/mlx5_rxtx_vec_neon.h > ./drivers/net/virtio/virtio_rxtx_simple_neon.c > ./drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c > ./drivers/net/i40e/i40e_rxtx_vec_neon.c > > Can we use a wildcard at dpdk root? > */*/*_neon.* > > The drivers/*/*/*_neon.* entry would still be needed though. > > > > > > IBM POWER (alpha) > > M: David Christensen <drc@linux.vnet.ibm.com> > > +F: config/ppc/ > > F: lib/librte_eal/ppc/ > > -F: drivers/net/i40e/i40e_rxtx_vec_altivec.c > > +F: drivers/*/*/*_altivec.* > > F: examples/l3fwd/*altivec.h > > Idem neon, lib files missing. > > ./lib/librte_eal/ppc/include/rte_altivec.h > ./lib/librte_acl/acl_run_altivec.c > ./lib/librte_acl/acl_run_altivec.h > ./lib/librte_lpm/rte_lpm_altivec.h > ./examples/l3fwd/l3fwd_altivec.h > ./examples/l3fwd/l3fwd_lpm_altivec.h > ./drivers/net/mlx5/mlx5_rxtx_vec_altivec.h > ./drivers/net/virtio/virtio_rxtx_simple_altivec.c > ./drivers/net/i40e/i40e_rxtx_vec_altivec.c > > > > > > Intel x86 > > M: Bruce Richardson <bruce.richardson@intel.com> > > M: Konstantin Ananyev <konstantin.ananyev@intel.com> > > +F: config/x86/ > > F: lib/librte_eal/x86/ > > Nothing for avx/sse ? I was not extending the scope too much. I think you're right, we can go further in apps and x86-specific files.