From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AD7F47EC7 for ; Fri, 29 Jun 2018 01:55:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2E6C021ABB; Thu, 28 Jun 2018 19:55:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Jun 2018 19:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=83GUOfynznnzfdQJA2jxMdn59g b+rGWE+plUALjGLgg=; b=nZUk8Ogf1kktSW9DthMDJdWxv/8u0jA5vRpmDmTcql ++rxHZON434S1YyRQKlKHbmmShhQto3vNjteU28zqKREop13+xNHlyaEIg8s3BZf fk44fywASuPUtj23HAxKeCFlzH1qPcs/eKEzhY1rz4w+Q+JEojhvHhB5bu12yihU A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=83GUOf ynznnzfdQJA2jxMdn59gb+rGWE+plUALjGLgg=; b=Hcn5nTdEtg6kcO+oqOyd3v VlVRRxZ0/V5qZvdFbUSAwNNkvW5dwhcArJkV4eX1FjDrD0X9RZGrhQJZveuaccpL 90ydJliJUF5IgfYI6ShLukDFwuRuoJwW1UQQpOMVw6ZlCEUuSY4lYGsW2VJccv36 PcCAQpNJo3465F8e9GefK0BbxwguP7QhswYaUZIlOXUziN2CHf2Jp1BCCVeC/TV5 1FRtXNQkjG9Fd4DRRWBxuiBpXy+rRZkKhQXUsxpxZKpuAAl5Eq1YFACV9d2ET6OL BAnuNuqkoN0w8FIcJXA4OgqtFN/yhf3nAz8eOFaieO5aU3+2BrfQVE9riO4COhPA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F5C210282; Thu, 28 Jun 2018 19:55:55 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Dan Gora Date: Fri, 29 Jun 2018 01:55:54 +0200 Message-ID: <1639218.dJ5v8slQoU@xps> In-Reply-To: <6fcf5346-318b-d773-82ee-d28489d6b2ae@intel.com> References: <20180620150122.45945-1-ferruh.yigit@intel.com> <6fcf5346-318b-d773-82ee-d28489d6b2ae@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 23:55:56 -0000 20/06/2018 19:15, Ferruh Yigit: > On 6/20/2018 6:07 PM, Dan Gora wrote: > > Hi Ferruh, > > > > The documentation for rte_eth_dev_configure() should get updated as > > well to document this requirement to strip the unsupported RSS hash > > function bits. The current documentation only refers to the tx/rx > > offload bits: > > > > * - Any offloading set in eth_conf->[rt]xmode.offloads must be within > > * the [rt]x_offload_capa returned from rte_eth_dev_infos_get(). > > * Any type of device supported offloading set in the input argument > > * eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled > > * on all queues and it can't be disabled in rte_eth_[rt]x_queue_setup(). > > Agreed, will update the patch according. I don't see the doc updated in your v2.