From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 7EBAC2965 for ; Fri, 11 Mar 2016 15:21:56 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id l68so19571457wml.1 for ; Fri, 11 Mar 2016 06:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=1xnsHW2ZvCvSaoJGoVZTcPH+j9VDk5wI2TKyNeneiGM=; b=RaPZ4JLxy3lQM0np4F8N+CjDKc0H2EgFPy/wfSphNHXS7gwnXoDrpDywStsnsHDhsr RBEhZYSGThXD0IdaGlthWrH3EgvYJYpOJ5Am9+q5PzV+eiklBiW5sG80FhVMmpy+sZ0r W1ivtpeYT69Bb8zcexcNXgKxMKaBVwXwctfruLo6QT/SWDRQUWh4Qcn707urXqJWmFBq OZBinsmnTzu3BPuoEfCjcSzSVnk+mLqs7awUywdmqogWpt/cD+kBZKMHdVP5JgFLRVhs M6aUoCLcCniYNx09vwsM2XzaodfiyOckcXdmpYB3mq5VIIvcG74b5S0v1kX0oliDqjMJ +q3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=1xnsHW2ZvCvSaoJGoVZTcPH+j9VDk5wI2TKyNeneiGM=; b=iZt6/TWeQcIlOD/femRoYj+7ZDrFFPdOhZ5ml9D3UdtHB/mzYkny0W47W6EY3EkdAr T0EavQ9VLEoTa8+TaZL/ATz9BMBl98FD20aAC+mgqyBjXK/AXOSh7GkCu8zivdt1TF45 zHJtql5HyJqPO0Rfos+6oubSw3qH30MIrrHXDsQnIRGdPWlUsfs6VNLBt8P4v3M6KWYj Oq+Vulaom7g1uPD4vNjbhcy5JfPi4FBx/eWAfem+C0L9zcVuBgpzGRNBoXmdYVzFcCRx Bur5k53cigbXRm4OC9tnZwKSGbWRUqj23fxunyDfEmFpIWTCMi7oIJ46KzGLgQ9nqIs+ 5nMg== X-Gm-Message-State: AD7BkJIeZqhPGvCSrDfmkIcBe9cxCUywdDHRZFVxjnCb2/8LIa4rNyBz3AmbgjmWJKoCTAZk X-Received: by 10.194.9.34 with SMTP id w2mr10010642wja.170.1457706116372; Fri, 11 Mar 2016 06:21:56 -0800 (PST) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id u16sm2555061wmd.5.2016.03.11.06.21.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Mar 2016 06:21:55 -0800 (PST) From: Thomas Monjalon To: "Zhang, Helin" Date: Fri, 11 Mar 2016 15:20:12 +0100 Message-ID: <16394562.fHpIIBU3jY@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1457627793-8491-1-git-send-email-helin.zhang@intel.com> <17578435.kLWYh0KOmD@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 14:21:56 -0000 2016-03-11 14:17, Zhang, Helin: > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Friday, March 11, 2016 7:20 PM > > To: Panu Matilainen; Zhang, Helin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether > > type > > > > 2016-03-11 13:19, Panu Matilainen: > > > On 03/11/2016 10:49 AM, Helin Zhang wrote: > > > > -int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, uint16_t > > > > tag_type); > > > > +int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, > > > > + enum rte_vlan_type vlan_type, > > > > + uint16_t tag_type); > > > > +int rte_eth_dev_set_vlan_ether_type_v22(uint8_t port_id, uint16_t > > > > +tag_type); int rte_eth_dev_set_vlan_ether_type_v1604(uint8_t port_id, > > > > + enum rte_vlan_type vlan_type, > > > > + uint16_t tag_type); > > > > > > > > /** > > > > * Set VLAN offload configuration on an Ethernet device > > > > > > Its nice to see people actually trying to be compatible on occasion :) > > > > > > However in this case there's not much point in doing so, because > > > libethdev ABI has already been broken in this cycle: > > > http://dpdk.org/browse/dpdk/commit/?id=cfd2279ea6299826fe992028f1dffaf > > > 9fa7e7d0a > > > > > > In other words, the compatibility versions can never get invoked > > > because all software built against libethdev needs to be rebuilt > > > anyway because of the soname bump. Just drop the compat versions, no > > > point carrying around something that cannot possibly get used. > > > > Oh yes, you are right. > > Sorry Helin for having required that extra work. > > On the good side, you have learnt how to do it ;) > > Yes, as Thomas said, at leat l know how to do that, and the extra work was not too big. > Thomas, Panu, thank you very much for the great comments! > > Thomas, does that mean I just need to work out a new version and just let the ABI > changes as is. No ABI annoucenment will be requried? No RTE_NEXT_ABI will be used? You just need an entry in "API changes" section of the release notes. You can state that this API change imply an ABI change. Thanks