From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 5657111DE for ; Fri, 22 Jul 2016 22:31:46 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id q128so69650842wma.1 for ; Fri, 22 Jul 2016 13:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=JF70KV42f/xqdsChz2R9cbZbBfRVZPTA/DH/5aN0AS0=; b=en856lhu+TtyxQeWSWDNS2ulL+NVL7sma1R4aboEhOlRf6osU8TIKegtENZCaAFmdp HaN2IB+h+gzQQD1VxVA9LB81rHBpfvuDWsMiCR8WptvH7FeZuPPulhhiyDjWhBKHJbZF 8aK5e9d5ZwyQ3GW/cUcaWFyRPyEXi3/nNNlXU0o3mELEF4gR7Kb1CJrS8V/PRDpfq8Aw vcZgzgiZocZaOjsfhJqKjnQlQIp7DtcA83tRAmxJqXFcwQ19SU560UwOhGwFzwW0/WOy bGXHvbr5e8glPrn17DeyOxbph2Iky9+eNL0QkmiRY5+rph1jPHs3WT4/cBovLp0E3IJJ F0oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=JF70KV42f/xqdsChz2R9cbZbBfRVZPTA/DH/5aN0AS0=; b=W4KwAiBzu7uy7MZf/eAh/nJLrHFWKMRrSIfyL6dT6gGQTC1CuTz20KcfxjfG1WoCnl 1206WDS8qNrPRJzUeS+UYmn9SGQlv77tI4qIFstzMhyXkaZFvi8gM/NA4V40/xIbMdQT Ylpp45A6+LQoUhGjNAI9tij0tpi/yD7t2E3rU4ViLUIM3KV7OZFN8IfQseqUUyr61L+h pInT68+9CIYOo+lfrffyDMReKW/ejiqoJKX21MgcizJhhLndE0LdLppGTTZfOhyxiMV7 6woATmiueigzVm9/YsZ/RbScSE92dDQjqky6vE8X5/3IjyA9TdeeTZxbYXyk6u2I9NU+ X7mA== X-Gm-Message-State: ALyK8tJEosiAFc+q6lZqd9k1moY3DvRKGOxZQzwYoAIOsecN30p0qrKwtJQ042kK0lDCiGia X-Received: by 10.28.223.139 with SMTP id w133mr27517725wmg.90.1469219504181; Fri, 22 Jul 2016 13:31:44 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id yz6sm2522263wjb.35.2016.07.22.13.31.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 13:31:43 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Yuanhan Liu , Christian Ehrhardt Date: Fri, 22 Jul 2016 22:31:42 +0200 Message-ID: <1642079.Fm0S65QgOZ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160722103634.GO28708@yliu-dev.sh.intel.com> References: <1469024670-4638-1-git-send-email-thomas.monjalon@6wind.com> <2761669.Unk5LuuApo@xps13> <20160722103634.GO28708@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] unify tools naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 20:31:46 -0000 2016-07-22 18:36, Yuanhan Liu: > On Fri, Jul 22, 2016 at 10:04:13AM +0200, Thomas Monjalon wrote: > > 2016-07-22 09:46, Yuanhan Liu: > > > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote: > > > > The following tools may be installed system-wise. > > > > > > Yes, indeed. Following is an example from dpdk package shipped in > > > ubutun 16.04: > > > > > > dpdk: /etc/dpdk/dpdk.conf > > > dpdk: /etc/dpdk/interfaces > > > dpdk: /etc/init.d/dpdk > > > dpdk: /lib/dpdk/dpdk-init > > > dpdk: /lib/systemd/system/dpdk.service > > > dpdk: /sbin/dpdk_nic_bind > > > dpdk: /usr/bin/dpdk_proc_info > > > dpdk: /usr/bin/testpmd > > > dpdk: /usr/share/doc/dpdk/changelog.Debian.gz > > > dpdk: /usr/share/doc/dpdk/copyright > > > dpdk: /usr/share/dpdk/tools/cpu_layout.py > > > dpdk: /usr/share/dpdk/tools/dpdk_nic_bind.py > > > dpdk: /usr/share/dpdk/tools/setup.sh > > > > > > > It may be cleaner and more convenient to find them with the same > > > > dpdk- prefix (especially for autocompletion). > > > > > > Agreed. > > > > > > > Moreover, the script dpdk_nic_bind.py deserves a new name because it is > > > > not restricted to NICs and can be used for e.g. crypto. > > > > > > Second that. But we might need doc the name change to let user aware of > > > that. > > > > There is a note in API changes section. > > And every references in the doc are renamed. > > > > > > These files are renamed: > > > > pmdinfogen -> dpdk-pmdinfogen > > > > pmdinfo.py -> dpdk-pmdinfo.py > > > > dpdk_pdump -> dpdk-pdump > > > > dpdk_proc_info -> dpdk-procinfo > > > > dpdk_nic_bind.py -> dpdk-devbind.py > > > > setup.sh -> dpdk-setup.sh > > > > > > > > The tools pmdinfogen, pmdinfo.py and dpdk_pdump are new in 16.07. > > > > > > > > The scripts dpdk_nic_bind.py and setup.sh may have been used with > > > > previous releases by end users. That's why a symbolic link still > > > > provide the old name in the installed tools directory. > > > > > > I was about suggesting the same thing: yes, we should keep the > > > backward compatibility. > > > > Does it mean you ack this patch? > > Yes, here is an explict one: > > Acked-by: Yuanhan Liu Applied