From: Thomas Monjalon <thomas@monjalon.net>
To: Huisong Li <lihuisong@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
andrew.rybchenko@oktetlabs.ru, konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag
Date: Sun, 04 Jul 2021 22:05:09 +0200 [thread overview]
Message-ID: <1644089.D8zZfYZZjn@thomas> (raw)
In-Reply-To: <1620460836-38506-1-git-send-email-lihuisong@huawei.com>
08/05/2021 10:00, Huisong Li:
> Currently, if dev_configure is not invoked or fails to be invoked, users
> can still invoke dev_start successfully. This patch adds a "dev_configured"
> flag in "rte_eth_dev_data" to control whether dev_start can be invoked.
[...]
> --- a/lib/ethdev/rte_ethdev_core.h
> +++ b/lib/ethdev/rte_ethdev_core.h
> @@ -167,7 +167,11 @@ struct rte_eth_dev_data {
> scattered_rx : 1, /**< RX of scattered packets is ON(1) / OFF(0) */
> all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */
> dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */
> - lro : 1; /**< RX LRO is ON(1) / OFF(0) */
> + lro : 1, /**< RX LRO is ON(1) / OFF(0) */
> + dev_configured : 1;
> + /**< Device configuration state:
> + * CONFIGURED(1) / NOT CONFIGURED(0).
> + */
Why not using "enum rte_eth_dev_state"?
Because rte_eth_dev.state is not shared between processes?
next prev parent reply other threads:[~2021-07-04 20:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 8:00 Huisong Li
2021-05-31 8:51 ` Huisong Li
2021-06-14 15:37 ` Andrew Rybchenko
2021-06-29 2:27 ` Huisong Li
2021-07-02 10:08 ` Andrew Rybchenko
2021-07-02 11:57 ` Ferruh Yigit
2021-07-02 13:23 ` Ananyev, Konstantin
2021-07-03 8:35 ` Huisong Li
2021-07-03 11:04 ` Ananyev, Konstantin
2021-07-05 3:03 ` Huisong Li
2021-07-05 9:50 ` Andrew Rybchenko
2021-07-05 11:22 ` Ananyev, Konstantin
2021-07-06 1:47 ` Huisong Li
2021-07-04 20:05 ` Thomas Monjalon [this message]
2021-07-05 3:18 ` Huisong Li
2021-07-05 6:07 ` Thomas Monjalon
2021-07-05 9:50 ` Andrew Rybchenko
2021-07-06 1:48 ` Huisong Li
2021-07-06 3:24 ` [dpdk-dev] [PATCH V1] ethdev: " Huisong Li
2021-07-06 4:10 ` [dpdk-dev] [PATCH V2] " Huisong Li
2021-07-06 8:36 ` Andrew Rybchenko
2021-07-07 2:55 ` Huisong Li
2021-07-07 8:25 ` Andrew Rybchenko
2021-07-07 9:26 ` Huisong Li
2021-07-07 7:39 ` David Marchand
2021-07-07 8:23 ` Andrew Rybchenko
2021-07-07 9:36 ` David Marchand
2021-07-07 9:59 ` Thomas Monjalon
2021-07-07 10:40 ` David Marchand
2021-07-07 10:57 ` Thomas Monjalon
2021-07-06 17:49 ` Ananyev, Konstantin
2021-07-07 9:53 ` [dpdk-dev] [PATCH V3] " Huisong Li
2021-07-08 9:56 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644089.D8zZfYZZjn@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=lihuisong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).