From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67B8541CEE; Mon, 20 Feb 2023 18:38:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5038D430B7; Mon, 20 Feb 2023 18:38:29 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 8D74440395 for <dev@dpdk.org>; Mon, 20 Feb 2023 18:38:27 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 34075320098F; Mon, 20 Feb 2023 12:38:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 20 Feb 2023 12:38:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676914705; x= 1677001105; bh=63fKrpPNSJy+9I2k6fVkR3pGZvauwrwlE9MTNqa3Ngw=; b=j UDYK/RGYcdZoYhv8D1NZrGUDTyPrmzEmI4xO7iGFSdOYvPxp6Vh4NMlV0YVB+vSM jh69rI4FSpslcIDrB1ZjjPlKibkJh5HCfDULNIKyThDEANV/qsgImWCF6WOqeIRu uAu4133Y4NqUgqsoFAPq/Gx8WieWad0i3xTatM+WKHC20itUb27bEI5uGMVSJwEQ fvC6ESaI/TDduM8bUZXCqn0gOboL0H/eezW1putQpQXfgyfqOEsjIgi5n+djE7mQ 2AnAR4m2ZgZlXkD/y32idUhNYqFB2wTFemdxMYF4pbb1l9fcClBUxxwEavEAyh6d idWIn/2LOxW7tV6A9xNuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676914705; x= 1677001105; bh=63fKrpPNSJy+9I2k6fVkR3pGZvauwrwlE9MTNqa3Ngw=; b=X 60oUA0nzt+Vr5lWyUhZSxXywtQMmdNbdAWlhsEaRKrxNT+jW5CYTblhcvt8C8ICg D9FZu7g8sYur6dfe6RvCvKqjkenOdbmpOKlZYBsteJWW03mknBZxnm3JC95HwPPH XnAYsY42MKRc+3Tr2oGbGsNzT96fRsENGLcqVdFzmJTh/pO+2eKNqgZWLp7a8zOd T8UdKoBvKkmZy7+VhlIEVSDY4rGjzjCVsVokKi6ajkXCnpRtQnDMbAxB897ETo/a oVze9jP89KqnqVQSCfF2njl9BXIWpSWSe9CUxQOvxbwSusFBPRd3sosaeZK7S0Yn 3aFYN9JRBiUaIBTxv+UOQ== X-ME-Sender: <xms:EbDzY2dpAQTR7Lngk54v1Uenv6_wCN643Fxsdc5s1bpOBvOe81pkcw> <xme:EbDzYwOHNr7dmfBQajrNtKG4eeqch5vLycYS56pOGhdBUL0Cf8QIsxkYleEYZKUk9 Q85YbX_wqthIXXWYQ> X-ME-Received: <xmr:EbDzY3iGqAJ-AA6zVKYDlb5Or6zi1OJI3TH5uxkGXGn3fajVFKd4YnJrrsDxVkTuQnCKUYHIkQzrydlMEuyKSBUfPg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejhedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeetgefgueetkefhffevheeigeelvdejhfffleefveefffdtudef jeeuiefhheejtdenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhj rghlohhnrdhnvght X-ME-Proxy: <xmx:EbDzYz99FNZucgsksrhLe8SwjkUvJsaCsOJkgZ7JBZSjdJ_nkEfHwg> <xmx:EbDzYyuyl-M0itHSxiZxAjpZIP0IsNSOGI1XnFuFBH72ELJvCHUxBw> <xmx:EbDzY6EaNDxsrRrXqntiAbRe-WxwJcoFspwu5FdZTtPF5hWZFZVjRg> <xmx:EbDzY0KsxfFmAPeUzUhJLyVZiDA7kJixw7L5HiChzHjyGgC0P6d60Q> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Feb 2023 12:38:24 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Bili Dong <qobilidop@gmail.com> Cc: yipeng1.wang@intel.com, Sameh Gobriel <sameh.gobriel@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org, cristian.dumitrescu@intel.com Subject: Re: [PATCH v3] hash: add XOR32 hash function Date: Mon, 20 Feb 2023 18:38:23 +0100 Message-ID: <16442264.0ZKypZ73Fx@thomas> In-Reply-To: <CAFnY8dHZ33SwP0PF9gpxrObL-Q0HPObrDRy+JT+EAfOc7WGzKA@mail.gmail.com> References: <20230215105442.3878441-1-qobilidop@gmail.com> <3296424.9LS3J3VOpE@thomas> <CAFnY8dHZ33SwP0PF9gpxrObL-Q0HPObrDRy+JT+EAfOc7WGzKA@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 20/02/2023 18:21, Bili Dong: > The naming is following the existing CRC32 hash: > https://elixir.bootlin.com/dpdk/v22.11.1/source/lib/hash/rte_hash_crc.h#L168. > I believe all existing hash functions in DPDK are 32 bits, so "32" didn't > appear in other hash function names. If we add "32" here, we probably > should also rename rte_hash_crc(). I'm fine with either option. Why all functions would be 32-bit? I don't think we need to rename all. We can just make the right thing when adding a new function. What maintainers of rte_hash think?