From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 3/8]app/test-pmd:test VxLAN packet identification
Date: Fri, 17 Oct 2014 09:41:08 +0200 [thread overview]
Message-ID: <1644288.qmWF3zu5IN@xps13> (raw)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D77681@SHSMSX101.ccr.corp.intel.com>
2014-10-17 05:23, Liu, Jijiang:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2014-10-11 13:55, Jijiang Liu:
> > > - "tx_checksum set mask (port_id)\n"
> > > + "tx_checksum set (mask) (port_id)\n"
> > > " Enable hardware insertion of checksum offload
> > with"
> > > - " the 4-bit mask, 0~0xf, in packets sent on a port.\n"
> > > + " the 8-bit mask, 0~0xff, in packets sent on a port.\n"
> > > " bit 0 - insert ip checksum offload if set\n"
> > > " bit 1 - insert udp checksum offload if set\n"
> > > " bit 2 - insert tcp checksum offload if set\n"
> > > " bit 3 - insert sctp checksum offload if set\n"
> > > + " bit 4 - insert inner ip checksum offload if
> > set\n"
> > > + " bit 5 - insert inner udp checksum offload if
> > set\n"
> > > + " bit 6 - insert inner tcp checksum offload if
> > set\n"
> > > + " bit 7 - insert inner sctp checksum offload if
> > set\n"
> > > " Please check the NIC datasheet for HW
> > limits.\n\n"
> > [...]
> > > .help_str = "enable hardware insertion of L3/L4checksum with a
> > given "
> > > - "mask in packets sent on a port, the bit mapping is given as, Bit 0 for
> > ip"
> > > - "Bit 1 for UDP, Bit 2 for TCP, Bit 3 for SCTP",
> > > + "mask in packets sent on a port, the bit mapping is given as, Bit 0 for
> > ip "
> > > + "Bit 1 for UDP, Bit 2 for TCP, Bit 3 for SCTP, Bit 4 for inner ip "
> > > + "Bit 5 for inner UDP, Bit 6 for inner TCP, Bit 7 for inner SCTP",
> > > .tokens = {
> > > (void *)&cmd_tx_cksum_set_tx_cksum,
> > > (void *)&cmd_tx_cksum_set_set,
> >
> > How is it related to VXLAN?
> > I may have missed something. But if not, I note the name of the reviewers ;)
>
> Yes, it is related to VxLAN Tx Checksum test, I will put the changes to test VxLAN Tx checksum patch.
Yes it must be moved in the patch related to checksum test.
--
Thomas
next prev parent reply other threads:[~2014-10-17 7:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 5:55 [dpdk-dev] [PATCH v5 0/8]Support VxLAN on Fortville Jijiang Liu
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 1/8]i40e:support VxLAN packet identification in librte_ether Jijiang Liu
2014-10-16 17:07 ` Thomas Monjalon
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e Jijiang Liu
2014-10-13 16:12 ` De Lara Guarch, Pablo
2014-10-16 10:19 ` De Lara Guarch, Pablo
2014-10-16 19:56 ` Thomas Monjalon
2014-10-17 5:58 ` Liu, Jijiang
2014-10-17 7:39 ` Thomas Monjalon
2014-10-20 1:25 ` Liu, Jijiang
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 3/8]app/test-pmd:test VxLAN packet identification Jijiang Liu
2014-10-16 20:01 ` Thomas Monjalon
2014-10-17 5:23 ` Liu, Jijiang
2014-10-17 7:41 ` Thomas Monjalon [this message]
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API Jijiang Liu
2014-10-15 16:01 ` De Lara Guarch, Pablo
2014-10-16 1:24 ` Liu, Jijiang
2014-10-16 12:41 ` De Lara Guarch, Pablo
2014-10-16 20:09 ` Thomas Monjalon
2014-10-17 6:53 ` Liu, Jijiang
2014-10-17 7:47 ` Thomas Monjalon
2014-10-20 1:22 ` Liu, Jijiang
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 5/8]i40e:implement API of VxLAN packet filter in librte_pmd_i40e Jijiang Liu
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 6/8]app/testpmd:test VxLAN packet filter API Jijiang Liu
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 7/8]i40e:support VxLAN Tx checksum offload Jijiang Liu
2014-10-16 20:34 ` Thomas Monjalon
2014-10-17 5:20 ` Liu, Jijiang
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 8/8]app/testpmd:test " Jijiang Liu
2014-10-11 7:28 ` [dpdk-dev] [PATCH v5 0/8]Support VxLAN on Fortville Liu, Yong
2014-10-11 7:56 ` Liu, Yong
2014-10-16 20:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644288.qmWF3zu5IN@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).