From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: bruce.richardson@intel.com, Ruifeng.Wang@arm.com,
Honnappa.Nagarahalli@arm.com, jerinjacobk@gmail.com,
ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH v2] config/arm: replace native machine args
Date: Tue, 02 Feb 2021 10:25:04 +0100 [thread overview]
Message-ID: <16452758.hIf2Js97NA@thomas> (raw)
In-Reply-To: <1612256727-9724-1-git-send-email-juraj.linkes@pantheon.tech>
02/02/2021 10:05, Juraj Linkeš:
> There are compiler issues when building with -mcpu=native with popular
> compilers, such as GCC-8.4:
> In file included from ../lib/librte_eal/arm/include/rte_vect.h:11,
> from ../lib/librte_net/net_crc_neon.c:10:
> ../lib/librte_net/net_crc_neon.c: In function ‘crcr32_folding_round’:
> /usr/lib/gcc/aarch64-linux-gnu/8/include/arm_neon.h:26094:1: error:
> inlining failed in call to always_inline ‘vmull_p64’: target
> specific option mismatch
> vmull_p64 (poly64_t a, poly64_t b)
> ^~~~~~~~~
> ../lib/librte_net/net_crc_neon.c:50:20: note: called from here
> uint64x2_t tmp1 = vreinterpretq_u64_p128(vmull_p64(
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> vgetq_lane_p64(vreinterpretq_p64_u64(fold), 0),
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> vgetq_lane_p64(vreinterpretq_p64_u64(precomp), 1)));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> and clang:
> gcc -E -dM -mcpu="native" - < /dev/null | grep __ARM_FEATURE_ATOMICS
> clang-9 -E -dM -mcpu="native" - < /dev/null | grep __ARM_FEATURE_ATOMICS
> <no output> # no clang support
>
> Fix this by always specifying the proper machine args and never using
> the native flags.
>
> Fixes: 78ac8eac7e8a ("config/arm: use native machine build arguments")
> Cc: juraj.linkes@pantheon.tech
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Applied, thanks
prev parent reply other threads:[~2021-02-02 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 14:55 [dpdk-dev] [RFC PATCH v1] config/arm: fix " Juraj Linkeš
2021-02-01 15:16 ` Thomas Monjalon
2021-02-02 7:40 ` Juraj Linkeš
2021-02-02 9:05 ` [dpdk-dev] [RFC PATCH v2] config/arm: replace " Juraj Linkeš
2021-02-02 9:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16452758.hIf2Js97NA@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=juraj.linkes@pantheon.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).