DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style
Date: Mon, 25 Oct 2021 22:21:45 +0200	[thread overview]
Message-ID: <1645491.BAsTB0IiB3@thomas> (raw)
In-Reply-To: <20210902090459.33d98d8e@hermes.local>

02/09/2021 18:04, Stephen Hemminger:
> On Thu, 2 Sep 2021 16:50:14 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
> > On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote:
> > > On Thu, 2 Sep 2021 09:10:47 +0100
> > > Bruce Richardson <bruce.richardson@intel.com> wrote:
> > >   
> > > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote:  
> > > > > This fixes most of the warnings from the Flake8 style checker.
> > > > > The ones remaing are long lines (we allow > 79 characters)
> > > > > and a line break warning.  The line break style changed in later
> > > > > versions of PEP 8 and the tool is not updated.
> > > > > 
> > > > > https://www.flake8rules.com/rules/W503.html
> > > > > 
> > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > > > ---
> > > > >  usertools/dpdk-devbind.py | 70 ++++++++++++++++++++++-----------------
> > > > >  1 file changed, 39 insertions(+), 31 deletions(-)
> > > > >    
> > > > Thanks for the cleanup.
> > > > 
> > > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>   
> > > 
> > > I don't use devbind (except in artifical testing), could someone with
> > > hardware make sure that nothing changed here.  
> > 
> > I didn't go testing with all possible options and inputs, but basic
> > operation for binding unbinding devices and giving error messages for
> > invalid device names works fine with this patch applied.
> > 
> > Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Thanks

Applied, thanks.



  reply	other threads:[~2021-10-25 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 21:27 Stephen Hemminger
2021-09-02  8:10 ` Bruce Richardson
2021-09-02 15:24   ` Stephen Hemminger
2021-09-02 15:50     ` Bruce Richardson
2021-09-02 16:04       ` Stephen Hemminger
2021-10-25 20:21         ` Thomas Monjalon [this message]
2021-09-02 10:32 ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1645491.BAsTB0IiB3@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).