From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 171EDA0C47; Mon, 25 Oct 2021 22:21:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 971DB40E3C; Mon, 25 Oct 2021 22:21:53 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 84CE84003E for ; Mon, 25 Oct 2021 22:21:51 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E431A3201FEA; Mon, 25 Oct 2021 16:21:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 25 Oct 2021 16:21:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Ht6FEbf4sMGBuhltVagkh6i8xpw/nj7HMIlCWTaIdW8=; b=Hb/BariBcL/JF0nb WpxMrcTC9LcV+EnNqdke6sd2Eb+4IJVdxZ1BNcU+VfCv7g77mgLsNHKAPwVbgPBn Cn/fkCO444kpqvLHfr62/wi3Nr4cKaDQu1EuCgrGsALxb1DQGRL2pF6FBzWF09ks tRIplcXAcR5Vt37tWkTZ/9z6HzlZi74PX0dzTTZUcBc2PkmKuc86wP+Dbsp7RHb/ 5EnDnzhX0capRaKQurxtH+z0qO7zqQQu8929EMRzr7EGRVA3kWrafqop8kXZ4o6M /BIgJUSLv9SDrvic3FoadT4m/BsDhDVzrrMDIj/9DXcdaRLiH9Pn9VHN1WzhFed4 y3GCkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Ht6FEbf4sMGBuhltVagkh6i8xpw/nj7HMIlCWTaId W8=; b=XJfLPazId8oLY8kMGxJ11j5vCh7kz1Qcil370+XL98UX43JW3hYDC4dRu Y3Vh8of6AtvO29fGBGPUYOtF1Aj1y898YPXvJsp6iZbrChYqjEcD0WYg9/jYv2V6 pnRjNdwx12CuYYM+QLAG4LYiMwJH5ddBvxHQJuuEkYjPSUTdnOsxBEZ5Rw4Z9Lre 5oImpwof9MR2VkbrPBhHWiv2abwzEmrqZ/XGJeie+Mr74+rZyf6NGzg4UDNemhM1 coCX7OwSXqgpGMNcaVjgR+j894GQIdL17SdEam42XJJPbvW2dW9a+i9V7quF1L0l ljV9P4HX0sgejvNGWruByy4R0L9Jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefhedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeuleevvdfhgeffveehleejtdelhfdvheeiheekkeeiudejheeh leehjeevfeffgeenucffohhmrghinhepfhhlrghkvgekrhhulhgvshdrtghomhenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshes mhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Oct 2021 16:21:46 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Bruce Richardson , dev@dpdk.org Date: Mon, 25 Oct 2021 22:21:45 +0200 Message-ID: <1645491.BAsTB0IiB3@thomas> In-Reply-To: <20210902090459.33d98d8e@hermes.local> References: <20210901212707.25079-1-stephen@networkplumber.org> <20210902090459.33d98d8e@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/09/2021 18:04, Stephen Hemminger: > On Thu, 2 Sep 2021 16:50:14 +0100 > Bruce Richardson wrote: > > On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote: > > > On Thu, 2 Sep 2021 09:10:47 +0100 > > > Bruce Richardson wrote: > > > > > > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > > > > > This fixes most of the warnings from the Flake8 style checker. > > > > > The ones remaing are long lines (we allow > 79 characters) > > > > > and a line break warning. The line break style changed in later > > > > > versions of PEP 8 and the tool is not updated. > > > > > > > > > > https://www.flake8rules.com/rules/W503.html > > > > > > > > > > Signed-off-by: Stephen Hemminger > > > > > --- > > > > > usertools/dpdk-devbind.py | 70 ++++++++++++++++++++++----------------- > > > > > 1 file changed, 39 insertions(+), 31 deletions(-) > > > > > > > > > Thanks for the cleanup. > > > > > > > > Acked-by: Bruce Richardson > > > > > > I don't use devbind (except in artifical testing), could someone with > > > hardware make sure that nothing changed here. > > > > I didn't go testing with all possible options and inputs, but basic > > operation for binding unbinding devices and giving error messages for > > invalid device names works fine with this patch applied. > > > > Tested-by: Bruce Richardson > > Thanks Applied, thanks.