From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 722B4A0C55; Wed, 13 Oct 2021 14:12:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B597410DA; Wed, 13 Oct 2021 14:12:46 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id DB1BC40E64 for ; Wed, 13 Oct 2021 14:12:44 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 8804C5C012C; Wed, 13 Oct 2021 08:12:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 13 Oct 2021 08:12:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= MO4UO/MnHR+nPue454SMmqPAVNSM15OQtcREIRoMu0Y=; b=Z8ZgdzDqT12hoZwi OM8kkHZyZdWv5uWTqmQqjkEFbq36XbeyB/jm7V+v7mdy1cxX7KPyo5nuf19cw30c zsm2S1fuxXyTKl9bY1J0f/lQiLfr2dDKw3Wpk7ILlKrDNOO7ErvbHfChdJSn5hFc kbzPoc/ChFqXyGB76pfga7CXMZ84zk426D/YALYEueUKsjIZoqK8DsQ3pSxk7P8G 2B/1Oe37/miQIT0Mo2KQGRuvsG6Tddk+zgE8GleuRtwx3/NYVZz1XsaMZNT8YZp5 zaj/MurXaQOrsvxJD0vjOe/Ygqe0yiEP10Hr+Nqk2VcxsePb13lAWd0ifx4tItUn YHw2iw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MO4UO/MnHR+nPue454SMmqPAVNSM15OQtcREIRoMu 0Y=; b=jbSbJOUUr0NaCEeuXVLvpwqlDmK6y4YuG0n1O0chrMU7L1YXyzvFakx2k 88uSa5LjDdjxNuw6aePIwAl2xKkkSn4lpkEmmGdajYA5X3i91h7F841SfkSg5kOf EVXG1kGS6dyFydbDsh+LYqvQ7AUmBupg4rDennj4NEPmVtq3xYkMplHMlAtzCPr5 H2ZzCzKhKzdoBvt0CqaHGgcGZlxmyb/VzfiqDsr2BuLiGPTGV2alqlypGl05DXHw G8/TN2iMkm7wMCbl8h4nxKdzdE+IhFoBZ8YmYQgCf2e9bT3vxMogrQ2fDMVT6oi5 gyEPoeZL5ZyC27k8KbEDrqdatvRFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 08:12:42 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Rahul Shah , "Kinsella, Ray" Cc: dev@dpdk.org, Cristian Dumitrescu Date: Wed, 13 Oct 2021 14:12:40 +0200 Message-ID: <1646223.B9qMf3zQby@thomas> In-Reply-To: References: <20210909164008.343712-1-rahul.r.shah@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] port: eventdev port api promoted X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" +Cc Cristian, the maintainer 10/09/2021 15:40, Kinsella, Ray: > On 10/09/2021 08:36, David Marchand wrote: > > On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: > >> On 09/09/2021 17:40, Rahul Shah wrote: > >>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, > >>> rte_port_eventdev_writer_ops symbols promoted > >>> > >>> Signed-off-by: Rahul Shah > >>> --- > >>> lib/port/version.map | 8 +++----- > >>> 1 file changed, 3 insertions(+), 5 deletions(-) > >> > >> Hi Rahul, > >> > >> You need to strip the __rte_experimental attribute in the header file also. > > > > That's what I first thought... but those are variables, and there were > > not marked in the header. > > My mistake - should have checked. > > > At least, those symbols must be alphabetically sorted in version.map. > > > > About checking for experimental mark on variables... I had a patch, > > but never got it in. > > I think we should instead (forbid such exports and|insist on) rework > > API / libraries that rely on public variables. > > I'll pull together a script to identify all the variables in DPDK. > Are you expecting the rework on the port api to be done prior to 21.11? Does it mean we should not promote these variables?