From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id A86527F25 for ; Fri, 7 Nov 2014 16:05:55 +0100 (CET) Received: by mail-wg0-f51.google.com with SMTP id l18so3943334wgh.38 for ; Fri, 07 Nov 2014 07:15:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=nXrFMobjRP49q4/OtUryvsT9y7bUntzmoBF21R8KAs4=; b=ZGyIja1Ociu+QyAo7bWhndJ4dqWmGlrpzFZzIqrY3JsDrsYgAfqj2BBkHLs8fjBims en0uKmmie8MflDpBgWniRpgHR76Mvo4wQrIuNHyXRcuPz7QltC4+e2VOZHQds4L0glYY 5bsWuKu7vTKYiLHh4UEsGTMvCJjjaVI66bN0wuka7O2jUpG2uUxioPxlB09TgLFJHGrl qf5VZ6SRr0zPepAv+KeKySiRLXKIGN1dyyaNIhhHaIDZVC31qRkvr8BSOI1hFReDsv+q KL3pgNxgknPtrDVHTftTa6Zt0R0qqn8BS8MDOSaZ9adeAzbens1etOmA4SupkXK5YqVq Setw== X-Gm-Message-State: ALoCoQmdPJq3nkXWgwNc16/F+tZszhUg/zVjOBGdYNXKHWTWk2WfXD0+fJimk89JFDBwaKw2DBAF X-Received: by 10.180.99.1 with SMTP id em1mr6028425wib.29.1415373327427; Fri, 07 Nov 2014 07:15:27 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id lp14sm437790wic.20.2014.11.07.07.15.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Nov 2014 07:15:26 -0800 (PST) From: Thomas Monjalon To: lxu Date: Fri, 07 Nov 2014 16:15:06 +0100 Message-ID: <1646488.MLiSkxW7Wj@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1415372269-8723-1-git-send-email-liang.xu@cinfotech.cn> References: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> <1415372269-8723-1-git-send-email-liang.xu@cinfotech.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7] eal: map uio resources after hugepages. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 15:05:55 -0000 Hi Liang, I see you are learning how to send a patch. It's a good thing. I don't know if the idea of your patch will be accepted but here are more tips about formatting: - You should use checkpatch.pl from kernel.org and fix the most important issues - The commit log should be wrapped to avoid long lines - The title is important. You didn't update it for vfio. And there should be no point at the end of the title. - You should use your real name in Signed-off-by. - You should annotate each new version to show the changes See http://dpdk.org/dev#send and https://www.kernel.org/doc/Documentation/SubmittingPatches Looking at other submissions could be inspiring also. Thanks -- Thomas