From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, Luca Boccassi <bluca@debian.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test-meson-build: fix check for whether meson has run
Date: Mon, 14 Jan 2019 12:19:08 +0100 [thread overview]
Message-ID: <16471174.gmsOdrL8Yx@xps> (raw)
In-Reply-To: <1547125801.16085.2.camel@debian.org>
10/01/2019 14:10, Luca Boccassi:
> On Thu, 2019-01-10 at 10:37 +0000, Bruce Richardson wrote:
> > The current check to see whether we need to call meson or just ninja
> > simply checked if the build directory existed. However, if meson was
> > run
> > but failed, the build directory would still exist. We can fix this by
> > instead checking for the build.ninja file inside the directory. Once
> > that
> > is present, we can use ninja safely and let it worry about rerunning
> > meson if necessary.
> >
> > Fixes: a55277a788df ("devtools: add test script for meson builds")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
prev parent reply other threads:[~2019-01-14 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 10:37 [dpdk-dev] " Bruce Richardson
2019-01-10 13:10 ` Luca Boccassi
2019-01-14 11:19 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16471174.gmsOdrL8Yx@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).