From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 51036C41E for ; Mon, 11 May 2015 15:46:27 +0200 (CEST) Received: by wicmc15 with SMTP id mc15so28615523wic.1 for ; Mon, 11 May 2015 06:46:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0LVPpatV9FSEg4tQycb9F1ztCEueEAZLk9PdyYnAx0Y=; b=QQIDpKo/ljtGqoGQGgCs7kbIIo9mU3F6PQLDFiC/RW5TTJfdoMjbOlN5Dd19gHpUj8 a5RvXrMT6AkES5D1dmcqOm/3Oc2pmolXsJQ1T0gHOlKlqKNsa0W2nJNSmEWjeobgvR9K QUWstpnXZbBmuqTgffyCjmNXHo9ETFYouUai2xfz+nqk0HjJp3fDV76ejnNclnPoZaIq Cy6Gemp1ICzKMnO/GnBDlv8PWLrqdjpJHw23Vzd8Sqrk/vButXGCnxDTdQdJ/zZQWSI3 yDhMINFFKvnXuT9er/9/OEm8t5zkQtZEtmlpdaoHKJRVPUE3WtC50HlN132qVzT+GHpC U0AQ== X-Gm-Message-State: ALoCoQkiWoo8Q+m9BNNR61/U5BlQQOQz3QcQO+v3NVPGbqdv4vjGg3SYDm1r3rcoPLMSmglAAHPB X-Received: by 10.180.84.201 with SMTP id b9mr19781536wiz.28.1431351987204; Mon, 11 May 2015 06:46:27 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a18sm22925534wja.46.2015.05.11.06.46.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 May 2015 06:46:26 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Mon, 11 May 2015 15:45:46 +0200 Message-ID: <1647994.EPP3JTkp5f@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <1430830054-28791-1-git-send-email-bruce.richardson@intel.com> References: <1430830054-28791-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/bsdapp: fix compilation on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 13:46:27 -0000 > Fixes: 6065355a "pci: make device id tables const" > > Following the above commit, compilation on FreeBSD with clang was broken, > giving the error message: > > .../lib/librte_eal/bsdapp/eal/eal_pci.c:438:16: fatal error: assigning to > 'struct rte_pci_id *' from 'const struct rte_pci_id *' discards qualifiers > [-Wincompatible-pointer-types-discards-qualifiers] > for (id_table = dr->id_table ; id_table->vendor_id != 0; id_table++) { > ^ ~~~~~~~~~~~~ > > This patch fixes the issue by adding "const" to the type of id_table. > > Signed-off-by: Bruce Richardson Applied, thanks