From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] link bonding unit test fix
Date: Fri, 01 Aug 2014 17:21:06 +0200 [thread overview]
Message-ID: <1648009.TlCDtWYl7N@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D89721C35052@IRSMSX103.ger.corp.intel.com>
2014-07-22 10:57, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> >
> > fix for link bonding unit tests which are failing due to change introduced in
> > rte_eth_dev_configure which now explicitly checks in pmd supports link status
> > chnage interrupts.
> >
> > Also adds some common test macros to the test application for unit testing
> >
> > Declan Doherty (2):
> > test app:
> > bond: unit test suite fix
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied for version 1.7.1.
> I would add that it may be a good idea to implement some of the changes made
> in this unit test in other ones (use the new macros).
Yes, it's cleaner with macros.
It would be a good idea to translate existing unit tests like Declan did.
Thanks
--
Thomas
prev parent reply other threads:[~2014-08-01 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 14:52 Declan Doherty
2014-07-21 14:52 ` [dpdk-dev] [PATCH 1/2] test app: Declan Doherty
2014-07-21 14:52 ` [dpdk-dev] [PATCH 2/2] bond: unit test suite fix Declan Doherty
2014-07-22 10:57 ` [dpdk-dev] [PATCH 0/2] link bonding unit test fix De Lara Guarch, Pablo
2014-08-01 15:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648009.TlCDtWYl7N@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).