From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id D7FC4B368
 for <dev@dpdk.org>; Fri,  1 Aug 2014 17:19:13 +0200 (CEST)
Received: by mail-wi0-f178.google.com with SMTP id hi2so1548463wib.5
 for <dev@dpdk.org>; Fri, 01 Aug 2014 08:21:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=3c1pBBH+L/KpUaU65EMjOzJ1ButEsVyJ+knOyJGCIQY=;
 b=YTjPY5HbPp7zW0MSNOrcl69qlp7sixVDgHZD4za4+EJTXV42kEhzgiqp+fReiGYg+/
 sF6UvY8Y0/TkquJtk0h+gg+YkCDPNL2iRw0T2NOJrSh51ckYacinKB9TRSzb6wAwn0Ui
 xJFcwmcBoeMQ6UP2fVhYHDgNRhmEEZF+XgrkxkzUlvUPoO/jBDAxiGgZpfsT588r/ZES
 GtuGQtLLQOoItIt2hdZqoU0iF+J3ZFSimMuaDdOTVZsMYDG/8mNd7ZZQHrBjsYI/EvdM
 8pt3olfUB2LzXeWfxhVkYs5puTnwboaKbEcXkaShigHvpjyPJGD+5xaP1ZP8IFbmzcVw
 o/fQ==
X-Gm-Message-State: ALoCoQmE/cTrt5cl/GaEdoKTZGJ2zjTEr/dJj3aHQ8HpyPjqe5U4qByZs3NbJ+aLksD7flGfrkP6
X-Received: by 10.180.36.238 with SMTP id t14mr8135932wij.38.1406906478249;
 Fri, 01 Aug 2014 08:21:18 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id pj6sm21608583wjb.21.2014.08.01.08.21.16
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 01 Aug 2014 08:21:17 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Date: Fri, 01 Aug 2014 17:21:06 +0200
Message-ID: <1648009.TlCDtWYl7N@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.7-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D89721C35052@IRSMSX103.ger.corp.intel.com>
References: <1405954337-28488-1-git-send-email-declan.doherty@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D89721C35052@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] link bonding unit test fix
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2014 15:19:14 -0000

2014-07-22 10:57, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> > 
> > fix for link bonding unit tests which are failing due to change introduced in
> > rte_eth_dev_configure which now explicitly checks in pmd supports link status
> > chnage interrupts.
> > 
> > Also adds some common test macros to the test application for unit testing
> > 
> > Declan Doherty (2):
> >   test app:
> >   bond: unit test suite fix
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied for version 1.7.1.

> I would add that it may be a good idea to implement some of the changes made
> in this unit test in other ones (use the new macros).

Yes, it's cleaner with macros.
It would be a good idea to translate existing unit tests like Declan did.

Thanks
-- 
Thomas