From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D71BA0524; Tue, 20 Apr 2021 12:06:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86BD3416DC; Tue, 20 Apr 2021 12:06:38 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 18AE5416DC for ; Tue, 20 Apr 2021 12:06:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 2906B1FC1; Tue, 20 Apr 2021 06:06:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Apr 2021 06:06:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= xjBVOH5EXZrZdK5afN4gHPqcIjuLwZT8RrYMvmAZo80=; b=jBFBAeGCotMr+fcV ubeamxJoZgoeNWxJcPzDeZyN0Xh5ybkIDphOEiEJM2r3PNzovt7ck5eEEOz1CIyc oe3SBAPnagUoD6xF6PdeAjRzFWDNuy8y+c1DMUSCZzUwCnGADEGdImZgL0Jfh5u9 g7AEhHAy0KxJjGsI3FiI3qPZvc2tSD2fhbhWmarlNgV+aD44UjZSM8YsabzJDdIt szWA0dp5X5JrADttoKmXeZgWORUOX8PZqhM+WyEIPC2qJkHn1cL0zT+tcfosdWa/ fipCScIKKXZ8jAaJLJYHC0MYld80Ye6FbBLK2vWYbtrY3uoNR8h72+tqX4+RiqLW Nj1hVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xjBVOH5EXZrZdK5afN4gHPqcIjuLwZT8RrYMvmAZo 80=; b=Kjou4uOHcTZtb6XZvX+EiV2xRmqnsKNgABkgtjXiCRczTcSGLJRIhTCjY 8UTYdYHwjAsagKgJaKo/vjbT6tNemYNyzFbvVYGbeQqp9EKnuxGRuHB6anbewA6t omEpuAeoorFV8F8M0/jZ3uviNXJo55zLK9LtjWM7b9l1O9ueRl5CHwQdXOQHvpR2 9BpWKUTo+Iu6Dk53INsTOAljmmVAi108Gp0rpETW29LkYeoaYvF971aXaZPjteKi TZ0EkQJVrmPC7qAETSfn+z8y3Ij/OLy4V3iQchvfPchL/jb43VXpFrNrkZdlMz3p ymoFFC0NUtVdk8UlDHVvZGTjy2ViA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtiedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 21863108005F; Tue, 20 Apr 2021 06:06:35 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" Cc: "dev@dpdk.org" Date: Tue, 20 Apr 2021 12:06:34 +0200 Message-ID: <1649627.coH7sy9KVI@thomas> In-Reply-To: References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <1799475.riq6yjk0ZW@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/04/2021 12:04, Dumitrescu, Cristian: > From: Thomas Monjalon > > 12/04/2021 01:23, Cristian Dumitrescu: > > > Each table entry is made up of match fields and action data, with the > > > latter made up of the action ID and the action arguments. The approach > > > of having the user specify explicitly the endianness of the action > > > arguments is difficult to be picked up by P4 compilers, as the P4 > > > compiler is generally unaware about this aspect. > > > > > > This commit introduces the auto-detection of the endianness of the > > > action arguments by examining the endianness of the their destination: > > > network byte order (NBO) when they get copied to headers and host byte > > > order (HBO) when they get copied to packet meta-data or mailboxes. > > > > > > The endianness specification of each action argument as part of the > > > rule specification, e.g. H(...) and N(...) is removed from the rule > > > file and auto-detected based on their destination. The DMA instruction > > > scope is made internal, so mov instructions need to be used. The > > > pattern of transferring complete headers from table entry action args > > > to headers is detected, and the associated set of mov instructions > > > plus header validate is internally detected and replaced with the > > > internal-only DMA instruction to preserve performance. > > > > > > Signed-off-by: Cristian Dumitrescu > > > --- > > > examples/pipeline/examples/vxlan.spec | 41 ++- > > > examples/pipeline/examples/vxlan_table.py | 44 ++-- > > > examples/pipeline/examples/vxlan_table.txt | 32 +-- > > > lib/librte_pipeline/rte_swx_ctl.c | 15 +- > > > lib/librte_pipeline/rte_swx_ctl.h | 6 + > > > lib/librte_pipeline/rte_swx_pipeline.c | 282 ++++++++++++++++++--- > > > lib/librte_pipeline/rte_swx_pipeline.h | 4 - > > > > There are compilation issues in the CI: > > https://patches.dpdk.org/project/dpdk/patch/20210411232338.4005-2- > > cristian.dumitrescu@intel.com/ > > > > Hi Thomas, > > The reason for the CI issues is because this patch set has dependencies on the previous patches that were pending, but now already applied by you (thank you!), so there should not be any real issues? Yes I didn't see any issue locally, just wanted to confirm.