From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4AF6AA0093;
Thu, 21 Apr 2022 11:20:58 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8A3FB4281E;
Thu, 21 Apr 2022 11:20:13 +0200 (CEST)
Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31])
by mails.dpdk.org (Postfix) with ESMTP id 21D1242806
for <dev@dpdk.org>; Thu, 21 Apr 2022 11:20:10 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1650532811; x=1682068811;
h=from:to:cc:subject:date:message-id:in-reply-to: references;
bh=yYyXFYqgz0puIq2GVHnWhzhyLTI1QjF0KdG3TdYh/GA=;
b=KsxiZDZBPzKtCO/zbwTOMATk5lvdcF7QH7V8HxLOyH/KYqKQycshnBWt
n7OspHm+igK2koQzuzgyxLauubvljpMVx4spe3OwG5OtAsz4L0zqqIn9h
wZrR+KNw0Ek3BkkyuvObKvC5+DRaO7l8t+hVe6wmUgPaxKlNMBOKrpuFn
3p/IzvjS7SuNjreYKDwNY8fnzy0OqtYeaY2ZzmMb2NVR5rUUsoUfiRMir
GMGGkTvN9lKaISfMVe/DXoJzwDdKsZdlr3MPbbStK+N2VpYCjhV/OiPhw
QeBqVdaNMi0pgRkriHBh6X6ld2jWGSYJ9PPlsitsELwLAZMidNvx/VkrO Q==;
X-IronPort-AV: E=McAfee;i="6400,9594,10323"; a="324734915"
X-IronPort-AV: E=Sophos;i="5.90,278,1643702400"; d="scan'208";a="324734915"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
21 Apr 2022 02:20:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,278,1643702400"; d="scan'208";a="593568352"
Received: from dpdk-dipei.sh.intel.com ([10.67.110.238])
by orsmga001.jf.intel.com with ESMTP; 21 Apr 2022 02:20:08 -0700
From: Andy Pei <andy.pei@intel.com>
To: dev@dpdk.org
Cc: chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,
changpeng.liu@intel.com
Subject: [PATCH v6 15/16] vdpa/ifc: blk device pause without no inflight IO
Date: Thu, 21 Apr 2022 16:33:53 +0800
Message-Id: <1650530034-59744-16-git-send-email-andy.pei@intel.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1650530034-59744-1-git-send-email-andy.pei@intel.com>
References: <1643093258-47258-2-git-send-email-andy.pei@intel.com>
<1650530034-59744-1-git-send-email-andy.pei@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
When virtio blk device is pause, make sure hardware last_avail_idx
and last_used_idx are the same.
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
drivers/vdpa/ifc/base/ifcvf.c | 2 +-
drivers/vdpa/ifc/base/ifcvf.h | 3 +++
drivers/vdpa/ifc/ifcvf_vdpa.c | 32 +++++++++++++++++++++++---------
3 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c
index d923266..d89cb73 100644
--- a/drivers/vdpa/ifc/base/ifcvf.c
+++ b/drivers/vdpa/ifc/base/ifcvf.c
@@ -118,7 +118,7 @@
IFCVF_WRITE_REG8(status, &hw->common_cfg->device_status);
}
-STATIC void
+void
ifcvf_reset(struct ifcvf_hw *hw)
{
ifcvf_set_status(hw, 0);
diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
index 7367094..f22d18b 100644
--- a/drivers/vdpa/ifc/base/ifcvf.h
+++ b/drivers/vdpa/ifc/base/ifcvf.h
@@ -157,6 +157,9 @@ struct ifcvf_hw {
int
ifcvf_init_hw(struct ifcvf_hw *hw, PCI_DEV *dev);
+void
+ifcvf_reset(struct ifcvf_hw *hw);
+
u64
ifcvf_get_features(struct ifcvf_hw *hw);
diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index f54beaf..578bf6c 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -351,23 +351,32 @@ struct rte_vdpa_dev_info {
vdpa_ifcvf_blk_pause(struct ifcvf_internal *internal)
{
struct ifcvf_hw *hw = &internal->hw;
- struct rte_vhost_vring vq;
int i, vid;
uint64_t features = 0;
uint64_t log_base = 0, log_size = 0;
uint64_t len;
+ u32 ring_state = 0;
vid = internal->vid;
if (internal->device_type == IFCVF_BLK) {
for (i = 0; i < hw->nr_vring; i++) {
- rte_vhost_get_vhost_vring(internal->vid, i, &vq);
- while (vq.avail->idx != vq.used->idx) {
- ifcvf_notify_queue(hw, i);
- usleep(10);
- }
- hw->vring[i].last_avail_idx = vq.avail->idx;
- hw->vring[i].last_used_idx = vq.used->idx;
+ do {
+ if (hw->lm_cfg != NULL)
+ ring_state = *(u32 *)(hw->lm_cfg +
+ IFCVF_LM_RING_STATE_OFFSET +
+ i * IFCVF_LM_CFG_SIZE);
+ hw->vring[i].last_avail_idx =
+ (u16)(ring_state & IFCVF_16_BIT_MASK);
+ hw->vring[i].last_used_idx =
+ (u16)(ring_state >> 16);
+ if (hw->vring[i].last_avail_idx !=
+ hw->vring[i].last_used_idx) {
+ ifcvf_notify_queue(hw, i);
+ usleep(10);
+ }
+ } while (hw->vring[i].last_avail_idx !=
+ hw->vring[i].last_used_idx);
}
}
@@ -751,7 +760,12 @@ struct rte_vdpa_dev_info {
if (ret)
goto err;
- vdpa_ifcvf_stop(internal);
+ if (internal->device_type == IFCVF_BLK) {
+ vdpa_ifcvf_blk_pause(internal);
+ ifcvf_reset(&internal->hw);
+ } else {
+ vdpa_ifcvf_stop(internal);
+ }
ret = vdpa_disable_vfio_intr(internal);
if (ret)
--
1.8.3.1