From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 97ABFA00C2;
Mon, 31 Oct 2022 21:13:25 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id F2D4941101;
Mon, 31 Oct 2022 21:13:24 +0100 (CET)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
[64.147.123.20])
by mails.dpdk.org (Postfix) with ESMTP id 16AE540223;
Mon, 31 Oct 2022 21:13:24 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailout.west.internal (Postfix) with ESMTP id 7990F3200902;
Mon, 31 Oct 2022 16:13:20 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Mon, 31 Oct 2022 16:13:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm3; t=1667247200; x=
1667333600; bh=0Ut2Wr21sCQRY8mJuad+8+Adq3w+//xWMKLrahaKb18=; b=c
+nV1HVx8mURu+uuWYVfrJsUDCkGvXRioxAQdg5RoPOoeoNJrgUe0TjzQFcZ9jtKS
nTh0/OL4oeZSlkGRcYniGrYMIb8pOeTuzgYsY4/+YBa86eUdXB++Lya3tK7dRNMI
Cp8FNMDF3CFlzdQcBFd+kTOvAnnYAmmR9erCGM0XHjo8HQr2MYDGEmz9EX+81izI
5wvDgJlvgxT2Y7cyEE5LwomxvZPRL6EyHjA6uP4fm+AOn68ma1n2l5uCDkDZcFb4
iHHUcgD41BH3UL7HrVcfF+Rc6V8TxcuPYi/E8nTuV4KBkodI/3zfR3L7QnnUoCFH
xz8WQgBMt4mPjutKbTong==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667247200; x=
1667333600; bh=0Ut2Wr21sCQRY8mJuad+8+Adq3w+//xWMKLrahaKb18=; b=t
L5EQUxf3+3wLSN6JokJkvJsoCsmzveMSSE66e95eWBtOIoboUm4NMTqilvcOkOXF
ErOlKOh9o0Kvmq8u+CLy4x6tMXtiIBtkiJD11FMN8Q9IGWv09mJXOVgwtUQfdxNs
s0Gp4qEYcSG9K8r3G1ems/ZaiMA7a2TRl0/4HRm3R2z6Y/P1XX9Wyox0N+Z/PCcA
LzCE5d3EW6B8+vl7Pg5SNsUBhNvWO/VPb8IpC0bVxU2apmL20z1nY1GP1jDZV5i+
bJ5KlGfK+OKKaT6ruobZl5lXurXbRhUlm+m9cYCPm8hRmeLzEPUfKj7WlW9OrT0A
fCbV33CRq3563vXNxYsrQ==
X-ME-Sender: <xms:XyxgY8r__B__3PBT3UQFEguhoZ82pwE3Oefb1FoKGxyBnMNH_6pxuA>
<xme:XyxgYyqBti5eHbBsuWdxSMy058Oh88cAEZ_X_bv8rBW9WIRgU5XgiGIL2eR5x010K
7pvmSspOExA_F_Khg>
X-ME-Received: <xmr:XyxgYxMT2VHnnYABosrVUL_uskXKgsS5iWMy_w_0GxCnLpZKUbBYUxACepDIpUZMMwuXsuAvMgLy5-PQTOR->
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudefgddufeegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:XyxgYz6d9zQGSnzH4H-6yw0Hb2_H3HX23uCZ34qsFdKqNMLrOmiuzQ>
<xmx:XyxgY75rH_p641gdzk8z2GEQEPGLx2mQAlmAvKa7H9weoL3Jz81xew>
<xmx:XyxgYzgwPFLyhBtFPzdzDZ5wLeyjX95TCn6fVU4CvQ8_kF6QuO3yGA>
<xmx:YCxgYxTqTkLxeoBZhmU9g9dy9xat1MW47AYdzcNB4N6LHlPjvJTcmg>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
31 Oct 2022 16:13:18 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bing Zhao <bingz@nvidia.com>
Cc: viacheslavo@nvidia.com, matan@nvidia.com, dev@dpdk.org, rasland@nvidia.com,
alialnu@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix the building with flexible array
Date: Mon, 31 Oct 2022 21:13:16 +0100
Message-ID: <16508820.Ash8RoxBsO@thomas>
In-Reply-To: <20221031182456.432384-1-bingz@nvidia.com>
References: <20221031182456.432384-1-bingz@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
31/10/2022 19:24, Bing Zhao:
> With some higher GCC/CLANG version, it is not recommended to use a
> structure with a tailing flexible array inside another structure.
> Accessing this array may be considered as a risk to corrupt the
> following field even if it is by intention.
>
> The error below was observed:
>
> drivers/net/mlx5/linux/mlx5_ethdev_os.c: In function 'mlx5_get_flag_dropless_rq':
> drivers/net/mlx5/linux/mlx5_ethdev_os.c:1679:42: error: invalid use of structure with flexible array member [-Werror=pedantic]
> 1679 | struct ethtool_sset_info hdr;
> | ^~~
>
> Changing it to memory dynamic allocation method will help to get
> rid of this complain.
>
> Fixes: e848218741ea ("net/mlx5: check delay drop settings in kernel driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks.
For an unknown reason, our GitHub CI started to fail on Sunday
with Fedora 35. Looks like an update was done in Fedora 35.
Now it is fixed!