DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
Date: Tue, 21 Oct 2014 10:36:22 +0200
Message-ID: <1652314.f9VDNlESRS@xps13> (raw)
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511878A4E@shsmsx102.ccr.corp.intel.com>

2014-10-21 08:28, Ouyang, Changchun:
> From: De Lara Guarch, Pablo
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > 2014-10-21 14:59, Ouyang Changchun:
> > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > > is disabled.
> > > >
> > > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > >
> > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > >
> > > Applied
> > 
> > I was checking this patch right now, and I come across a second compilation
> > issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> > declared, and Bond PMD and IP fragmentation libraries use those functions.
> > 
> > I guess that it is late to NACK this :P, but we require a second patch to fix
> > completely this issue.
> 
> As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)

Exact

> In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
> Yes, agree with you, we need another patch to fix compilation issue in other both places.

Yes, I'm aware of these limitations.
Please, first explain why mbuf refcnt is needed for these features.
Then we have 2 options: remove the dependency or add more ifdefs.

Thanks
-- 
Thomas

  reply	other threads:[~2014-10-21  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21  6:59 Ouyang Changchun
2014-10-21  8:04 ` Thomas Monjalon
2014-10-21  8:19   ` De Lara Guarch, Pablo
2014-10-21  8:28     ` Ouyang, Changchun
2014-10-21  8:36       ` Thomas Monjalon [this message]
2014-10-21 13:45         ` Doherty, Declan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1652314.f9VDNlESRS@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git