From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id DDEF57E7B
 for <dev@dpdk.org>; Tue, 21 Oct 2014 10:28:26 +0200 (CEST)
Received: by mail-wi0-f175.google.com with SMTP id d1so9330847wiv.8
 for <dev@dpdk.org>; Tue, 21 Oct 2014 01:36:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=S195lUNWrcDzR+LxhjpOqvDahjicZp6c3LnjigG05HE=;
 b=hF89AlOb5vuiby3kd/Ar603ocZX/h0SzZtOLhFYUzQrkYnBEEJmyNQgwXCi3au0zwI
 dmLVtnpEFsgxF4pOs0qLbN2eGV5ZgXIMqwR7lfSHIi9g2LKgiVtLBwGKC8jrN3CKEOxn
 8m5doMQ3fsFx4mNjvoZAF5a5Qnj9GzWkT0ynnk4vHC/RYsXVFqUTU2y4NYKqE8/dchNS
 9ngCERwX7md7MiwewdYOBY5EI9dC2dZnFnMOL+762sc+HuSWGxZ+IkpqJZMxow1fkk/3
 ZQSXdaIWYTCv1zcf7jcYCBbLNo1P63Cs7OKlvTLslexh5ogUEYscwj6SHPt6IMnYJFjc
 QPNA==
X-Gm-Message-State: ALoCoQmlFsr0QKiY2NbntfWT2b6lk+6gcATaueE/SlGHUXyKyDzMGqb8/9yPICwPBzwUuVzOEGc6
X-Received: by 10.180.184.129 with SMTP id eu1mr26378800wic.69.1413880600717; 
 Tue, 21 Oct 2014 01:36:40 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ky3sm14579915wjb.39.2014.10.21.01.36.39
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 21 Oct 2014 01:36:40 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>, "De Lara Guarch,
 Pablo" <pablo.de.lara.guarch@intel.com>
Date: Tue, 21 Oct 2014 10:36:22 +0200
Message-ID: <1652314.f9VDNlESRS@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511878A4E@shsmsx102.ccr.corp.intel.com>
References: <1413874756-18669-1-git-send-email-changchun.ouyang@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8972262DE86@IRSMSX108.ger.corp.intel.com>
 <F52918179C57134FAEC9EA62FA2F962511878A4E@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2014 08:28:27 -0000

2014-10-21 08:28, Ouyang, Changchun:
> From: De Lara Guarch, Pablo
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > 2014-10-21 14:59, Ouyang Changchun:
> > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > > is disabled.
> > > >
> > > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > >
> > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > >
> > > Applied
> > 
> > I was checking this patch right now, and I come across a second compilation
> > issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> > declared, and Bond PMD and IP fragmentation libraries use those functions.
> > 
> > I guess that it is late to NACK this :P, but we require a second patch to fix
> > completely this issue.
> 
> As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)

Exact

> In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
> Yes, agree with you, we need another patch to fix compilation issue in other both places.

Yes, I'm aware of these limitations.
Please, first explain why mbuf refcnt is needed for these features.
Then we have 2 options: remove the dependency or add more ifdefs.

Thanks
-- 
Thomas