From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5027BA00BE; Thu, 28 May 2020 13:29:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 376CB1DB87; Thu, 28 May 2020 13:29:15 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0E76737B0 for ; Thu, 28 May 2020 13:29:14 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 45F8E5C01B4; Thu, 28 May 2020 07:29:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 28 May 2020 07:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 2U4dqrpZUI2nOgMG8gIg/hNSNqIE5aN4nPiXr5RYsaE=; b=IKVqAGEE6SX9p8WB MO4yNoI9gR07Ig3ERrSNDwmhYi8vLwRa7Tck37cKdNhO/gifG4Iu8uqcIt0qJk52 mEcltKclS5mSnbsfM9efV4asOgCouu646eYFEXLKZWDI8ptPsCR08Z44KVYwCRS8 hY8uE3FiuL/3QS+hn++M64nz5dKK4oyCBWauALs9iWdJ8xaPmPwsRDmuvMZ7ejxz RUsroNPHMQh/7dBD2S4yGowTltXH7R6GqMbwP92IMJYVaLtbkqRq1UQ5tcXpNPP5 wAiNHr3YRLP96wzAmBruXZsPo+4HpOvicHd581HUiCx89xYEqqdqpU0lOw89rPUo Q1g2uw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2U4dqrpZUI2nOgMG8gIg/hNSNqIE5aN4nPiXr5RYs aE=; b=x/efp8myz3q1riaT57npupLE523xoKikxqK9M8I2A3Rdoywdf2b4yPDWR YK/7Niz9ycy9JTp5bwztxBXEIxQ+A9hc21/9guJLw7a/2GdQzAUwmjlVLR/y3pKC LNvOXjA+ujMoaBKanYzCeNSHuGwxPFf4b1TVqJVIEJXkofmtJXCaJNgTZgd+56Je RwFYWnxOth+ssTcpBhp6fqiAfgtfK6zfQcP576FgwaZY0SNEiIyPvy4zgkfVR6r6 c1LiK8Lkc/54mIkk0oV/FgmgF4xeQwp0q5WpB8vcZDb9kvPdm2PC4NB4yOIlpU2G P8g88qlfdUt/znyMl6pnAhcGH0FwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddviedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E1C333280060; Thu, 28 May 2020 07:29:11 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Anatoly Burakov , Bruce Richardson Date: Thu, 28 May 2020 13:29:10 +0200 Message-ID: <1652982.mC0pzBW6Ph@thomas> In-Reply-To: <20200528130922.1606a8b0@sovereign> References: <20200428235015.2820677-1-dmitry.kozliuk@gmail.com> <1739619.a3TOMyy0yD@thomas> <20200528130922.1606a8b0@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 02/11] eal: introduce internal wrappers for file operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/05/2020 12:09, Dmitry Kozlyuk: > On Thu, 28 May 2020 09:59:13 +0200 > Thomas Monjalon wrote: > > > 25/05/2020 02:37, Dmitry Kozlyuk: > > > * eal_file_lock: lock or unlock an open file. > > > * eal_file_truncate: enforce a given size for an open file. > > [...] > > > Implementation for Linux and FreeBSD is placed in "unix" subdirectory, > > > which is intended for common code between the two. Files should be named > > > after the ones from which the code is factored in OS subdirectory. > > [...] > > > lib/librte_eal/unix/eal_unix.c | 51 ++++++++++++++++++++++ > > > > Why naming this file eal_unix? > > If it's truly global, it should be unix/eal.c > > We've already discussed this: Makefiles are written in such way that files in > common and arch directories must have distinct names for OS-specific ones. > Until Makefiles exist, this is consistent naming with the rest of librte_eal. Oh right. > > If it's only about file operations, it could be unix/eal_file.c > > Good suggestion, given that more file-related functions are expected to be > extracted here in future (e.g. for tracing). > > > Please update MAINTAINERS when creating a new file. > > All files or directories must be listed in MAINTAINERS, > > even if there is no maintainer for them. > > Will do. Thanks