From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id E8E7DC310
 for <dev@dpdk.org>; Tue, 14 Apr 2015 16:00:10 +0200 (CEST)
Received: by widjs5 with SMTP id js5so89150473wid.1
 for <dev@dpdk.org>; Tue, 14 Apr 2015 07:00:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=yTQI7PnaoT4Km8ATbCkZHagaBLCuvrjLVjJ2rUPHtPI=;
 b=HbCMsOytqa6oPnbdFFtLzdUCZlWKrh1BCvn29zFqv5RwezbkaYdGyG1PzN9N52nnEs
 5JZ4Y51DkwJvaZWB9QqfhnusiqpKGXAnkVPgKrjj7ZhzcERUhLvyBXCloSzYB5CCh8+s
 tFsuUlOD29c5LS6F5jEHvE8ira4B2UtN1UQV8pCcHk3YMb5k6mW7keLWNG+4HpiLgnsf
 2CYB1FfX2Q5CpGHn3hh07pNAUKBPhqfzt9FURUbSp1qdvDPv9ge1YuiuDpKYgJS8KFf0
 1isfTXuKXoTKXJrKS5cJLqh/FsFpYfQKOOWDGd19Qc69h+bAgFHMEl3Sl4IHgk+LvjuR
 DiGQ==
X-Gm-Message-State: ALoCoQnF9pU08nYBhpQcbZ/rZoxYyZxWZR3Lnm1AW2M49u9SnirCRQVaS7UgzQxzmwyNKLih69nZ
X-Received: by 10.180.88.72 with SMTP id be8mr13686798wib.42.1429020010722;
 Tue, 14 Apr 2015 07:00:10 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id eh5sm2932916wic.20.2015.04.14.07.00.08
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 14 Apr 2015 07:00:09 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Date: Tue, 14 Apr 2015 15:59:28 +0200
Message-ID: <1653003.yPkaDFgZKF@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1428608412-31191-2-git-send-email-rkerur@gmail.com>
References: <1428608301-31033-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-2-git-send-email-rkerur@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2015 14:00:11 -0000

Hi Ravi,

2015-04-09 12:40, Ravi Kerur:
> --- a/lib/librte_eal/common/eal_common_thread.c
> +++ b/lib/librte_eal/common/eal_common_thread.c
[...]
> +#ifdef RTE_EXEC_ENV_BSDAPP
> +#include <pthread_np.h>
> +#include <sys/thr.h>
> +#else /* RTE_EXEC_ENV_BSDAPP */
>  #include <pthread.h>
> +#endif /* RTE_EXEC_ENV_BSDAPP */
[...]
> +#ifdef RTE_EXEC_ENV_BSDAPP
> +	RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%p;cpuset=[%s%s])\n",
> +		lcore_id, thread_id, cpuset, ret == 0 ? "" : "...");
> +#else /* RTE_EXEC_ENV_BSDAPP */
> +	RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%x;cpuset=[%s%s])\n",
> +		lcore_id, (int)thread_id, cpuset, ret == 0 ? "" : "...");
> +#endif /* RTE_EXEC_ENV_BSDAPP */

These lines should stay in bsdapp and linuxapp directory.
You can add a new function to eal_thread.h to format the thread id,
so you'll be able to use %s in generic log above.