From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F10A442D26; Thu, 22 Jun 2023 19:38:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77E4840DDA; Thu, 22 Jun 2023 19:38:05 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1F92F406BA; Thu, 22 Jun 2023 19:38:04 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B896E5C010C; Thu, 22 Jun 2023 13:38:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 22 Jun 2023 13:38:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687455483; x=1687541883; bh=D0MEdEV+FBQ2YxsnJdvIfWEZK5CLEDoqwKX tqf6N/TI=; b=knlmXj1FMyBUjCQ1SKU7EIj4TFCdEOxD5mPPBBoBydfBEftp0+5 H6s0j6gfWNsX2kwsd3Xn1cDt8gZteoWK/YEf/WBgBOyuQX+H+SBcBI0a0sk/qbt6 Ky4NA2qfZX13zkQmMvEVEKIQEbq51Y7hj5gbyHI5OZREcaKMpNIRbVUoYUT9R3A0 H4HoAX/mKTN43tAFAFDPfUK1iYzGbRj4EzBwFkPbCETFdx4gTElTIwSI/1vmfcWC +aopGbwBPjS46YwcEgFOr/Vv+Q5Dj2Wz6iYLSRG6AA+nj0lu6Vjga5DoLrH0K8Xs +MKMguC6p3mFZZ1GkDr88rBXHD4Rp21lzIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687455483; x=1687541883; bh=D0MEdEV+FBQ2YxsnJdvIfWEZK5CLEDoqwKX tqf6N/TI=; b=ahRtEec8XjHFfuPMg8cgnu1hXkABAZYWvE5KGi1C2JabW+YOp1F ZO36iJ9DWTAI9MUFPEQHmcYoDsNOQ8bThxY2ndsWQKicBYsKKT7aD7MEBGVY8OX4 bpgimC68bIPDy+/lW3yYRRArd4COQawT26Eh3D3ddYplMao+xGlAlPY6PyPHxSok uaAzKaYWTX9Ti1jrHem4JBDYMbMIls+cCXh5VFGTEjodCmlhFtjN2kBLWg2XywA4 lEwtBon6Iqe+C/tMw+22XSGRFFVYMkfkZpGXcq8sQZXNAPBxiJePL3ZvwTNHxiwT y9BxNnvpkarbW1XhJ69q7CcG2Xd1HGhSIYg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeguddguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedv ieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jun 2023 13:38:01 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Olivier Matz , Dekel Peled , Andrew Rybchenko , Bruce Richardson Subject: Re: [PATCH] mbuf: fix doxygen for distributor metadata Date: Thu, 22 Jun 2023 19:38:00 +0200 Message-ID: <16545382.geO5KgaWL5@thomas> In-Reply-To: References: <20230615134942.3393383-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/06/2023 16:19, Bruce Richardson: > On Mon, Jun 19, 2023 at 09:37:09AM +0200, David Marchand wrote: > > On Thu, Jun 15, 2023 at 5:15=E2=80=AFPM Bruce Richardson > > wrote: > > > > > > On Thu, Jun 15, 2023 at 03:49:42PM +0200, David Marchand wrote: > > > > /**< is for post annotations. > > > > > > > > Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteri= a") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: David Marchand > > > > --- > > > > lib/mbuf/rte_mbuf_core.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > > > > index c692c33ec4..2030b3bef9 100644 > > > > --- a/lib/mbuf/rte_mbuf_core.h > > > > +++ b/lib/mbuf/rte_mbuf_core.h > > > > @@ -584,8 +584,8 @@ struct rte_mbuf { > > > > * @see rte_event_eth_tx_adapter_txq_= set() > > > > */ > > > > } txadapter; /**< Eventdev ethdev Tx adapter = */ > > > > - /**< User defined tags. See rte_distributor_p= rocess() */ > > > > uint32_t usr; > > > > + /**< User defined tags. See rte_distributor_p= rocess() */ > > > > > > Yes, this fixes the issue, but... > > > I dislike having the comment on the line under the item in question. I > > > think the post-annotation comments should only be used for comments o= n the > > > same line. If the comment is to be on a different line, I think it sh= ould > > > go on the previous line to the item. I also think this tends to be the > > > style used throughout DPDK generally. > >=20 > > I dislike post annotations (regardless of being on the same line or > > not) as it is easy to mix the description of fields in a structure. > > But this file has many other usages of this form and, in doubt, I > > aligned to them. > >=20 > > I can send a followup cleanup if you want, is that ok for you? > >=20 >=20 > If this is consistent with what is already done in the file, then I'm ok > with it as a fix. Follow-up cleanup is obviously welcome, but doesn't have > to be you doing it. >=20 > Acked-by: Bruce Richardson Applied, thanks.