From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 71B0311F5 for ; Mon, 29 Sep 2014 21:54:32 +0200 (CEST) Received: by mail-wi0-f170.google.com with SMTP id n3so176321wiv.3 for ; Mon, 29 Sep 2014 13:01:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=HzHBwIWZWrnnj0cBgWhXBPmTeh4ZyLPHhNFUqUT4YZI=; b=SgJI4AVezBcoVKKN3EjNvb9s0NMVf5dMJFzHtcIb5bVDAznNZLzZJppyFZ9CUapc/R FspeKLXLjEMPPgd5YErZ/KPjmizLRMswn1b6ys8QgP9NttryCxLAQk+5sRjP2G+nYomT szL0XNhLwGopvKR7rKIOZ7FhuZr0JJa6EuGER1Y77JNOyw5yLJTLe8zS2O9/ZZvfjkVe tz+OZ7VrMNBGJURwxBuiKmIJprvQ3oxCitnXGKCNk0fIQ2PYYpqZRNNjvIdhHqxcYJVv XaoJNYJGQkR2PXKz36f6qFAYal0nhL00Q5Ch9HsVLqUh4TBdjeN5FafCAMS7tpn9yVn9 SoIg== X-Gm-Message-State: ALoCoQnx5w6n0trkoOPNC98gb/9ZBwR+vstyI26PATgERJQu0lD6zHydgA6iF/SuWfWyTtEqlMCe X-Received: by 10.180.208.13 with SMTP id ma13mr162515wic.53.1412020869772; Mon, 29 Sep 2014 13:01:09 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id v9sm16810283wjy.14.2014.09.29.13.01.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Sep 2014 13:01:08 -0700 (PDT) From: Thomas Monjalon To: Huawei Xie Date: Mon, 29 Sep 2014 22:00:55 +0200 Message-ID: <1654692.MNslQ8lvdC@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1774915.lz9MF51vUa@xps13> References: <1411724758-27488-1-git-send-email-huawei.xie@intel.com> <1411724758-27488-3-git-send-email-huawei.xie@intel.com> <1774915.lz9MF51vUa@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 02/11] lib/librte_vhost: refactor vhost lib for subsequent transform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 19:54:32 -0000 2014-09-29 21:55, Thomas Monjalon: > 2014-09-26 17:45, Huawei Xie: > > This patch does simple split of the original vhost example source > > files in vhost lib directory. > > vhost rx/tx functions virtio_dev_rx/tx are copied from main.c to > > new file vhost_rxtx.c and license header is added. > > main.c and main.h are removed and will be copied to new vhost > > example in subsequent patch. > > virtio-net.h is renamed to rte_virtio_net.h as API header file. > > > > Signed-off-by: Huawei Xie > > You are removing functions for mergeable buffer feature. > Please keep it instead of re-adding it later. Other comment, you are silently increasing these values to 64: #define MAX_PKT_BURST 32 /* Max burst size for RX/TX */ #define MAX_MRG_PKT_BURST 16 /* Max burst for merge buffers. Set to 1 due to performance issue. */ -- Thomas