DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, dmitry.kozliuk@gmail.com,
	anatoly.burakov@intel.com,
	Tyler Retzlaff <roretzla@linux.microsoft.com>,
	Narcisa Vasile <navasile@microsoft.com>
Subject: [PATCH v3 5/6] test/threads: add tests for thread attributes API
Date: Wed, 22 Jun 2022 13:26:20 -0700	[thread overview]
Message-ID: <1655929581-12366-6-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1655929581-12366-1-git-send-email-roretzla@linux.microsoft.com>

test basic functionality and demonstrate use of following thread
attributes api. additionally, test attributes are processed when
supplied to rte_thread_create().

    * rte_thread_attr_init
    * rte_thread_attr_set_affinity
    * rte_thread_attr_get_affinity
    * rte_thread_attr_set_priority

Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 app/test/test_threads.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 72 insertions(+), 1 deletion(-)

diff --git a/app/test/test_threads.c b/app/test/test_threads.c
index 1077373..3c22cec 100644
--- a/app/test/test_threads.c
+++ b/app/test/test_threads.c
@@ -17,7 +17,9 @@
 static uint32_t
 thread_main(void *arg)
 {
-	*(rte_thread_t *)arg = rte_thread_self();
+	if (arg != NULL)
+		*(rte_thread_t *)arg = rte_thread_self();
+
 	__atomic_store_n(&thread_id_ready, 1, __ATOMIC_RELEASE);
 
 	while (__atomic_load_n(&thread_id_ready, __ATOMIC_ACQUIRE) == 1)
@@ -166,6 +168,73 @@
 	return 0;
 }
 
+static int
+test_thread_attributes_affinity(void)
+{
+	rte_thread_t thread_id;
+	rte_thread_attr_t attr;
+	rte_cpuset_t cpuset0;
+	rte_cpuset_t cpuset1;
+
+	RTE_TEST_ASSERT(rte_thread_attr_init(&attr) == 0,
+		"Failed to initialize thread attributes");
+
+	CPU_ZERO(&cpuset0);
+	RTE_TEST_ASSERT(rte_thread_get_affinity_by_id(rte_thread_self(), &cpuset0) == 0,
+		"Failed to get thread affinity");
+	RTE_TEST_ASSERT(rte_thread_attr_set_affinity(&attr, &cpuset0) == 0,
+		"Failed to set thread attributes affinity");
+	RTE_TEST_ASSERT(rte_thread_attr_get_affinity(&attr, &cpuset1) == 0,
+		"Failed to get thread attributes affinity");
+	RTE_TEST_ASSERT(memcmp(&cpuset0, &cpuset1, sizeof(rte_cpuset_t)) == 0,
+		"Affinity should be stable");
+
+	thread_id_ready = 0;
+	RTE_TEST_ASSERT(rte_thread_create(&thread_id, &attr, thread_main, NULL) == 0,
+		"Failed to create attributes affinity thread.");
+
+	while (__atomic_load_n(&thread_id_ready, __ATOMIC_ACQUIRE) == 0)
+		;
+
+	RTE_TEST_ASSERT(rte_thread_get_affinity_by_id(thread_id, &cpuset1) == 0,
+		"Failed to get attributes thread affinity");
+	RTE_TEST_ASSERT(memcmp(&cpuset0, &cpuset1, sizeof(rte_cpuset_t)) == 0,
+		"Failed to apply affinity attributes");
+
+	__atomic_store_n(&thread_id_ready, 2, __ATOMIC_RELEASE);
+
+	return 0;
+}
+
+static int
+test_thread_attributes_priority(void)
+{
+	rte_thread_t thread_id;
+	rte_thread_attr_t attr;
+	enum rte_thread_priority priority;
+
+	RTE_TEST_ASSERT(rte_thread_attr_init(&attr) == 0,
+		"Failed to initialize thread attributes");
+	RTE_TEST_ASSERT(rte_thread_attr_set_priority(&attr, RTE_THREAD_PRIORITY_NORMAL) == 0,
+		"Failed to set thread attributes priority");
+
+	thread_id_ready = 0;
+	RTE_TEST_ASSERT(rte_thread_create(&thread_id, &attr, thread_main, NULL) == 0,
+		"Failed to create attributes priority thread.");
+
+	while (__atomic_load_n(&thread_id_ready, __ATOMIC_ACQUIRE) == 0)
+		;
+
+	RTE_TEST_ASSERT(rte_thread_get_priority(thread_id, &priority) == 0,
+		"Failed to get thread priority");
+	RTE_TEST_ASSERT(priority == RTE_THREAD_PRIORITY_NORMAL,
+		"Failed to apply priority attributes");
+
+	__atomic_store_n(&thread_id_ready, 2, __ATOMIC_RELEASE);
+
+	return 0;
+}
+
 static struct unit_test_suite threads_test_suite = {
 	.suite_name = "threads autotest",
 	.setup = NULL,
@@ -175,6 +244,8 @@
 		TEST_CASE(test_thread_create_detach),
 		TEST_CASE(test_thread_affinity),
 		TEST_CASE(test_thread_priority),
+		TEST_CASE(test_thread_attributes_affinity),
+		TEST_CASE(test_thread_attributes_priority),
 		TEST_CASES_END()
 	}
 };
-- 
1.8.3.1


  parent reply	other threads:[~2022-06-22 20:26 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 13:58 [PATCH 0/6] add thread lifetime and " Tyler Retzlaff
2022-06-09 13:58 ` [PATCH 1/6] eal: add thread attributes Tyler Retzlaff
2022-06-09 13:58 ` [PATCH 2/6] eal: add thread lifetime management Tyler Retzlaff
2022-06-09 13:58 ` [PATCH 3/6] eal: add basic rte thread ID equal API Tyler Retzlaff
2022-06-09 22:24   ` Konstantin Ananyev
2022-06-10 22:48     ` Tyler Retzlaff
2022-06-11 12:25       ` Konstantin Ananyev
2022-06-13 13:39         ` Tyler Retzlaff
2022-06-10  0:40   ` fengchengwen
2022-06-09 13:58 ` [PATCH 4/6] test/threads: add tests for thread lifetime API Tyler Retzlaff
2022-06-09 13:58 ` [PATCH 5/6] test/threads: add tests for thread attributes API Tyler Retzlaff
2022-06-09 13:58 ` [PATCH 6/6] test/threads: remove unit test use of pthread Tyler Retzlaff
2022-06-14 23:47 ` [PATCH v2 0/6] add thread lifetime and attributes API Tyler Retzlaff
2022-06-14 23:47   ` [PATCH v2 1/6] eal: add thread attributes Tyler Retzlaff
2022-06-14 23:47   ` [PATCH v2 2/6] eal: add thread lifetime management Tyler Retzlaff
2022-06-18 12:59     ` Dmitry Kozlyuk
2022-06-20 17:39       ` Tyler Retzlaff
2022-06-21 16:24       ` Tyler Retzlaff
2022-06-21 18:51       ` Tyler Retzlaff
2022-06-21 19:44         ` Dmitry Kozlyuk
2022-06-21 21:28           ` Tyler Retzlaff
2022-06-21 22:24             ` Dmitry Kozlyuk
2022-06-22 18:21               ` Tyler Retzlaff
2022-06-14 23:47   ` [PATCH v2 3/6] eal: add basic rte thread ID equal API Tyler Retzlaff
2022-06-20  8:34     ` Konstantin Ananyev
2022-06-14 23:47   ` [PATCH v2 4/6] test/threads: add tests for thread lifetime API Tyler Retzlaff
2022-06-14 23:47   ` [PATCH v2 5/6] test/threads: add tests for thread attributes API Tyler Retzlaff
2022-06-14 23:47   ` [PATCH v2 6/6] test/threads: remove unit test use of pthread Tyler Retzlaff
2022-06-22 20:26 ` [PATCH v3 0/6] add thread lifetime and attributes API Tyler Retzlaff
2022-06-22 20:26   ` [PATCH v3 1/6] eal: add thread attributes Tyler Retzlaff
2022-06-22 20:26   ` [PATCH v3 2/6] eal: add thread lifetime management Tyler Retzlaff
2022-06-22 20:26   ` [PATCH v3 3/6] eal: add basic rte thread ID equal API Tyler Retzlaff
2022-06-22 20:26   ` [PATCH v3 4/6] test/threads: add tests for thread lifetime API Tyler Retzlaff
2022-06-22 20:26   ` Tyler Retzlaff [this message]
2022-06-22 20:26   ` [PATCH v3 6/6] test/threads: remove unit test use of pthread Tyler Retzlaff
2022-06-27 16:56 ` [PATCH v4 0/6] add thread lifetime and attributes API Tyler Retzlaff
2022-06-27 16:56   ` [PATCH v4 1/6] eal: add thread attributes Tyler Retzlaff
2022-06-27 16:56   ` [PATCH v4 2/6] eal: add thread lifetime management Tyler Retzlaff
2022-06-27 16:56   ` [PATCH v4 3/6] eal: add basic rte thread ID equal API Tyler Retzlaff
2022-06-27 16:56   ` [PATCH v4 4/6] test/threads: add tests for thread lifetime API Tyler Retzlaff
2022-06-27 16:56   ` [PATCH v4 5/6] test/threads: add tests for thread attributes API Tyler Retzlaff
2022-06-27 16:56   ` [PATCH v4 6/6] test/threads: remove unit test use of pthread Tyler Retzlaff
2022-07-31 21:16   ` [PATCH v4 0/6] add thread lifetime and attributes API Dmitry Kozlyuk
2022-09-21  8:15   ` David Marchand
2022-09-29  7:02     ` David Marchand
2022-10-05 16:11     ` Tyler Retzlaff
2022-10-05 16:34       ` Tyler Retzlaff
2022-10-06  6:52         ` David Marchand
2022-10-06 15:14           ` Tyler Retzlaff
2022-10-06 13:36         ` Thomas Monjalon
2022-10-06 15:10           ` Tyler Retzlaff
2022-10-06 15:14             ` Thomas Monjalon
2022-10-06 15:20               ` Tyler Retzlaff
2022-10-06 15:26                 ` David Marchand
2022-10-06 15:27                   ` Tyler Retzlaff
2022-10-05 17:07 ` [PATCH v5 " Tyler Retzlaff
2022-10-05 17:07   ` [PATCH v5 1/6] eal: add thread attributes Tyler Retzlaff
2022-10-06  8:32     ` David Marchand
2022-10-05 17:07   ` [PATCH v5 2/6] eal: add thread lifetime management Tyler Retzlaff
2023-03-01  8:11     ` David Marchand
2023-03-01 20:34       ` Tyler Retzlaff
2022-10-05 17:07   ` [PATCH v5 3/6] eal: add basic rte thread ID equal API Tyler Retzlaff
2022-10-05 17:07   ` [PATCH v5 4/6] test/threads: add tests for thread lifetime API Tyler Retzlaff
2022-10-06  8:32     ` David Marchand
2022-10-06 15:19       ` Tyler Retzlaff
2022-10-05 17:07   ` [PATCH v5 5/6] test/threads: add tests for thread attributes API Tyler Retzlaff
2022-10-05 17:07   ` [PATCH v5 6/6] test/threads: remove unit test use of pthread Tyler Retzlaff
2022-10-06 19:25   ` [PATCH v5 0/6] add thread lifetime and attributes API David Marchand
2022-10-07 19:20     ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1655929581-12366-6-git-send-email-roretzla@linux.microsoft.com \
    --to=roretzla@linux.microsoft.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=navasile@microsoft.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).